[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/12] x86/p2m: {get,set}_entry hooks and p2m-pt.c are HVM-only
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 30 Apr 2021 12:57:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5zTE5dBoG/zjo9xrFuZxsi1ZDaDLyRIvBc5Zey3+Mg8=; b=cbhisrRPq05yhqU/UpzZ8GKaebSh/K1soXnydYPyxlwd+8arOYFnJ5k1EtGbAeqpHvE7Bq3upFQOWMe3KG9rShjNP6cB4JSO5yzb7ilUo4Y8Od/5tADC+Tj2vgOazfXeQHR4HQaCRJAZ9pBHfjTAJex3wf4KIp8bQVp7ryEGLZDHhVeRONOLxxoaggO6VpuWtf9aGkpcw10HTi+EHeKHysk4efVGRyqxs2M6fdJGpAODungwjufmMRKB1olcYjx74nEefBPcsQY7e758pxrLTWpAyspVOKWUkL1KOsObcxBF0p8ASVPjE0l/9WUltB3yxBJFIZry7yUO6LUbNVFL6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DtawxO57zkenmpYelBvQOEF0wHdkHFTLYAKlWnQiNriewcr05spQpbm3K4cnSazVwXlRWK4tE6TRUZkIv44Cv7QsbjhflAxHtq18pnlGxz5N8Qcf5CdboUdvQ5S3NONu+eXqV/MJhGvEE1kYiTgSZTr+XgRuLPSBpcahmQkaICrnXWj8NBXduZdtlJgA/I5sV3sp1HxhGAUrWYqbaKMF6jy1uPsjog99oAoXCxtb48WKHIw3NWIYiOc155vYUE3RQXxwdqEsU/67Xh0VNhLEcsd6JiTJ3c1+sR7TAy9qhIBNTBgcMMVkeNiKZlBdAcPjI6ydJtO7CmaoAHNyCkKPaw==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 30 Apr 2021 10:57:40 +0000
- Ironport-hdrordr: A9a23:g0ErWa+NvLdmLZzMjwluk+FocL1zdoIgy1knxilNYDRvWIixi9 2ukPMH1RX9lTYWXzUalcqdPbSbKEmyybdc2qNUGbu5RgHptC+TLI9k5Zb/2DGIIUHD38Zn/+ Nbf6B6YeecMXFTkdv67A6kE9wp3dmA9+SSif3Dymp2JDsKV4hLxW5Ce2GmO2dxQxRLAod8OZ qH/8xcpyehf3N/VLXAOlAuWe/fq9rX0K/8aRkdCBI9rCWIhzWk6Ln1eiLooys2eTVJ3Lsk7C z5gxX0j5/TyM2T5z398yvo75pQkMb80dcrPqKxo+UcNzmEsHfLWK1PQLuH1QpFxd2HyFFvq9 XUpgdlAsIb0QKsQkiQgT/Anzbtyywv7XiK8y7pvVLGrdbiTDw3T+pt7LgpCyfx0EYrsNFi3K 8j5Qvw3PA2fHCw7hjV3NTGWwpnkUC5uxMZ4JYupkdSTJcEb/tppZEflXklYasoJj7w64wsDY BVfafhzctRGGnqC0zxjy1ExdyhWWkLBRGWQkQOkdz96UkpoFlJi2Qf38ARhXEG6dYUTIRF/f 3NNuBSmKhJVdJ+V9MwOM4xBe+MTkDdSxPFN2yfZXzhCaE8InrI77r6+q886u2GcIEBpaFC16 jpYRd9jyofakjuAcqB0Nlg6RbWWliwWjzr14V3+4V5kqeUfsuqDQSzDHQV1+ewqfQWBcPWH9 ypPohNPvPlJWzyXa5UwgzFXYVII3V2arxVhv8LH3a15u7bIIzjseLWNNzJIqD2LDoiUmTjRl QZWjzeI9hB81CLVnf0jAO5YQKuRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbR1O25ZGOX dWEffCqOeWtGO29WHH4yFCIRxGFHtY573mTjdvrQ8OOEXkTKYbt7ykCCRv9UrCAiU6Y9LdEQ ZZqVgy07mwNYasyScrDM/iFW6GkX0JpjavQ40HkqOOoefpE6lIQKoOaehUL0HmBhZ1kQFlpC NocwkfXHLSETvolOGCl5wbBObWcvFmmwe1KctoqXbS3H/s5v0Hdz8+ZXqDQMSXiQEhS35/nV tq6ZISh7KGhHKSM2cluf85N1dNcWyTJ7pDAG2+FcJps4GuXDs1YXaBhDSchR12Xmbx7U0dil bsKjCudejRDkBQvW1Z1ajW4Ep5H1/tDH5YWzRfi8lQBG7GsnF83auwaq2/33C4R3ECzuseWQ u1Kgc6E0dL/ZSaxRSVkDGNGTEa3Z0oJPXaF6lmWarUwGmRJIqBkrwmE/dY8I1+Ds3ntvYGXI ukCkmoBQK9L9ls9x2ep34jNiUxlWItlunw3gb5qEe/x3wyDJPpUSJbboBeB+vZyWfqR/yFis okyf00uPa9KWX3ZJqtz7rNYztKNxPUpiqXQogT2ORplJN3kIE2OZ/RFQbs/jVg+j4VKc/vjk MQQKhh+tn6S8dSVv1XXxgcx0YjkdSEEVAivQP3CNIvZF1FtQ6vA/q5p57z7Yc1CkKPpAHMKU CS3i1U8fDCRTaC39chetUNCFUTTEg383J5+uyeM6XWFQWxbulGlWDKeEOVQft4SKKfH68XoQ s/y9aUn/WPfy69/AzLpzN0LuZv9GmgKPnCTT6kKKpt89agP06LjbbvyMmvjC3vQT/+Un8mv+ R+BAUtR/UGrCIjgo0x2jWzTaKygntNqSog3RhX0nj32oan52/HG1phKgOxuOQOYQVu
- Ironport-sdr: ySjvVM7JfuhNMr0y+nWvweZ9G3UHRrtUHMZuqfnF+dyav79C+SQowDuYVAhlgrVi8zJO6fAbcn sc6uHdJqgedDi2T9eNkiHp/Lj19jIMyk3sEiKlIgktWux+fdw4bOPqQuOJUEnTs2tfLJs4WKLX rLPTV59wDEDaj+j7wvRYRziio6Pi9YDfyENP1XbWH6/5Te6B12TwECcaYWSrsXfhth9d177UPp 7lqSIVlxpMyK0VOerd/DjMse0eRhy1zEMUmCjkxcxwO0ZvVXARMCAyUkOKN45ol8VUHj9NUjQg PvA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Apr 12, 2021 at 04:13:19PM +0200, Jan Beulich wrote:
> With the hooks no longer needing setting, p2m_pt_init() degenerates to
> (about) nothing when !HVM. As a result, p2m-pt.c doesn't need building
> anymore in this case, as long as p2m_pt_init() has proper surrogates put
> in place.
>
> Unfortunately this means some new #ifdef-ary in p2m.c, but the mid-term
> plan there is to get rid of (almost) all of it by splitting out the then
> hopefully very few remaining non-HVM pieces.
>
> While the movement of the paging_mode_translate() check from
> p2m_remove_page() to guest_physmap_remove_page() may not be strictly
> necessary anymore (it was in an early version of this change), it looks
> more logical to live in the latter function, allowing to avoid acquiring
> the lock in the PV case. All other callers of p2m_remove_page() already
> have such a check anyway (in the altp2m case up the call stack).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
