[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Luca Fancellu <luca.fancellu@xxxxxxx>
  • Date: Tue, 4 May 2021 14:09:09 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8dFEG5o76gj/8Zyki+POmpxp3gzwAy7gksoi/WRfFQ=; b=TdbeRfAerBSyDWQ3NhWGXRWZOg6LkjXOOPOMAvi1d755KMkl135hCZDP2vbuvPT8/z7WiJkVCnhaOJO/3xRqasiUYt6O95yhJc8xh7GXBPeVKJGspCw28V1eFYgfN+LZezTTQWv0/U+SytZwAraLH8i+IYP+6+rty40499wnfTr2jWQTbqMUI7KGHzA11SfRS3hdA5uYSOnke0PZZORaAYTAGSLy2ilx3dOFiT/p+/c8cyEARsEtxAc3TOcrrIq0Oj9GGZafoZYJwOXKarp95GQ4CBL6SFsP7PJZLG4JxWfhSzGDiUhDn5iZ4BMg+qDyZ7LlG8m3TAsnk7kRHBDqtw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIYhVptjxI3wrwT8OGi6ofFr7U3VQxfREcX+Zs22NNiSe4QHzLkp3ZK2HSmgHgGCBPuzDxurMj0C/yrTE8ztCGMVOgdZCcwifWAasK4XTRu+gJFTKcMxSVhjirkK/OO4B/4ia8ZcW/oMqxnZzFMcm4aEBmZxA48AagqfswLbLR+1fUBYbf8y3qii/9p6PLgFVj6gUDGwJuWICulDxT1QoKN1J7uLLWtIs1dGhHMttoe8cda31Rz/BmFjVp7vRr4CKIWNfP+HagKNs244Z/kRLk8ZGyZ8Ywe2aG7z+LaLM48JNeYqsk8sQgfXjykHqjI/l7xhu3uj1jJR8UY57AOAYw==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 04 May 2021 13:09:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;


> On 4 May 2021, at 12:48, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 04.05.2021 11:46, Luca Fancellu wrote:
>> @@ -451,11 +466,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t);
>>  * bytes to be copied.
>>  */
>> 
>> -#define _GNTCOPY_source_gref      (0)
>> -#define GNTCOPY_source_gref       (1<<_GNTCOPY_source_gref)
>> -#define _GNTCOPY_dest_gref        (1)
>> -#define GNTCOPY_dest_gref         (1<<_GNTCOPY_dest_gref)
>> -
>> struct gnttab_copy {
>>     /* IN parameters. */
>>     struct gnttab_copy_ptr {
>> @@ -471,6 +481,12 @@ struct gnttab_copy {
>>     /* OUT parameters. */
>>     int16_t       status;
>> };
>> +
>> +#define _GNTCOPY_source_gref      (0)
>> +#define GNTCOPY_source_gref       (1<<_GNTCOPY_source_gref)
>> +#define _GNTCOPY_dest_gref        (1)
>> +#define GNTCOPY_dest_gref         (1<<_GNTCOPY_dest_gref)
> 
> Didn't you say you agree with moving this back up some, next to the
> field using these?

Hi Jan,

My mistake! I’ll move it in the next patch, did you spot anything else I might 
have forgot of what we agreed?

Cheers,
Luca

> 
> Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.