[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 13/13] libs/guest: (re)move xc_cpu_policy_apply_cpuid


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 4 May 2021 15:08:51 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 04 May 2021 14:09:00 +0000
  • Ironport-hdrordr: A9a23:OFf9ZK0nRQ0PPfE/XoX74wqjBR50eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/NIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFnNJ1/Z xLN5JzANiYNzNHpO7x6gWgDpIEyN6I7KiniY7lvg9QZCtBApsB0y5SDAGHHkpqACxPApQkHJ SRj/A33AaIU3IRc8i9Gz05T/HOzue72q7OTBYaC3ccmW+zpByy7rqSKXal9zcbSjVV3L8k+2 StqX2c2oyGk9WWjiDRzHXS6ZM+oqqh9vJmCNaXgsYYbhXA4zzYHbhJYLGJsDArrOzH0j9D/L bxii09NMd+4W65RBDXnTLR2hLt2Dtry3juxU7wuwqHneXFRSk3A8cEuIRBchGx0TtDgPhA1s twvl6xht5yN1ftjS7979/HW1VBjUyvu0M4neoSlXBEFaMDdb54t+UkjR5oOaZFOBi/xJEsEe FoAs2Zzu1Ra0midHzcvnNi2piFQmkzOhuNQ0AEutaQugImwExR/g89/ogyj30A/JUyR91v/O LfKJ1ymLVPVMMNKYpgGeY6R9etAGCle2OSDEuiZXDcUI0XMXPErJD6pJ8v4vuxQYcFyJsplI 6Ee3lz3FRCKH7GOImr5tlm4xrNSGKyUXDG0cdF/aFjtrn9XrbwdQyCUk0piNvImYQ3PuTrH9 KIfL5GCf7qKmXjXaxT2RflYoJfLXkFXNdQgdowW0uPrsXXbrSw8tHKafq7HsvELR8UHkfERl cTVjn6I8tNqmqxXGXjuQPcX3P2dla6x7hUeZKqrtQ7+cwoDMlhowIVgVO26oWgMjtZqJUscE 9/Or/81p6hrW6t5GDS8lhzMhVTDkxp8KztOkk6+zMiAgfRS/Iuqt+fcWdd0D+sPRlkVfrMHA pevVhsvaqxMpyL3CgnT8isOmWRiXwPqGOWJq1szZGr1IPAQNcVH5wmUKt+GUHgDBpugz9wpG NCcgMfAkfCCzXgj766hIcYCOy3TagpvC6bZepv7V7Pv0SVos8iAlEBWSS1aNWahQY1SyARgl Fq6acQjKCHhS2kJQIE8bQFGWwJTF7SLKNNDQyDaokRsKvsYhtIVmuPhSaXkVU0YWrl90Ibg2 blLSGSZPHTCldRoXxDyM/RgQFJX1TYW3g1RmFxsIV7G2iDkG10y/Wzfaa203GccB8a2ecWPC vebTZXKRMrxNaqzxmcnTaEGxwdt8MTF92YKI5mX6DY23urJoHNv7oBBeVs55pgNMrjqKsXSu qZYRaSNy7kEOsn1Ayeu2Y9NEBP2SwZuMKt/CegwHmz3XY5D/aXCk9hXasnL9aV6HWhb+qU0b 1i5OhF/9eYAyHUUJqr2KvXZzlMJlf4umitVdwlrphSoOYbqKZzJZ/GSjHFvUs3mSkWHYPRrg czUa576LfONstEZMoJYR9U+VIviZCpIFY0tBf1RsszZ0skgXOeH97h2cuNlZMfRmm64CfgM1 iW9CNQu93fWTGY6LIcA6UsZWtMbkwx72lj4fOCe4XcBB7CTZAEwHOKdluGNJNNQqmMHrsd6j xg5cuTouORfy3knADc1AELe55mwiKCe4efEQiMEelH/5iRIlKXmJan58a1kXPyQTu/YEIImJ 1deSUrH5x+owhnqLdy/jm5S6TxrE5guUBZ+ytbmlnk3ZXj5nzaE0FAOQjQmY5XQjFXL3iNga 3+gK+l/UW4xAIA9YjIFU9WcN0LMcMXVJLLIyBnLtVVoKSl5LM1giNIYA4nCmk1jDyV5ZI84Z 6JnNHpH8HyA3bhPlwMvRFCHZB9hSEqrm9kdc6mhKjNIjk/J6otOb8S94pWmDVmphzP9FUadQ xqrRFt/JrKNEbbM3N1ErXOkYP6jAMDnrWL70RjqRxr6wmaoWDZn2Kwvs6u/1IosmXWr2Zc2N +gbQp0pBwciylK7uhKNGGXXWvlXHWfWWmHsZcACDlCEm4mzOU5hAfCKa4rmpiyw3F/lC82GC Qq3L2nf1yvYgm6JJnXNzClFNO8HdhoRe1eU1BzbEKeBVD8gZQ3VRLUaL5ap3KRs38TGKmDPb 6nagqBDJ8LuLcdIbDoXpT2v7a+6iFV8mhXtpn8hGCOgZtRnL+mDwN4qJYnf6BiJwet+05Do6 WudA/LJswJ7DrOr2rngB4oW+M+0kAbx1IXqjwXHz7tD9SvRlt5rDpD0JPxQjYEoPzxBep9oC PFrBq5o3/dOBqPPETEYcx431s5sALASpndpV60Zv74MA1T4uilFc6C5GDH/h6fo9WKlz/FsB xxlWtaWBUu0g+QGNAcEW3fwUxfMx1iEHpX4Uef87tY5ntsnkk/dDMNAMEF4SXyEBjZSzT+my 64H0oHy6gXF2tuweRZtXtBhUwv3FcSULRnj52K7FOgbH1NQApAz8cf4jH+2/AVRjB7IQv8Ie D0sN+kL4Cx0pBWEyuV4/8FIPd6Ax4/wo799a3aU2ZOfg6Y1bBcwV7W4Rk69UEkgNJgu0f6go fUFwKDl4NBp+oAT+vyiS8yRPoCJ4U7oHyKHcZa9rUrw0j59NPQ3iozZqGw5BlEaBzbIeJqaV UydzOVgfkjwMqH5CedeZhtrqTd0So6Ze3NXExOtbzaPDJH+OEv3N7WZI7SJTTbp8lEEfkC2n 7+nDcD4nupnZ++Fpq0PBC4hiuKVWMrCI5AG0ptB+HQLaIIy4wCj15akrY8Oh1Z6MgOIxWvvN ILuDfxhI5VvIErrgVYQeqqhCBTxQ4=
  • Ironport-sdr: 3a6uvkaCaYepdXZRr2xQWHzr8026Xrcda7gERbnf22cG8ya7Hm8M1lIyF8kqUGW+1Q1tL4M+/P J5rS9UegAzsSfV8F3OCoQNSto330MNgJoMPsPpoVEuQUvDLOuvgV6VTllMVdV2JYzWdAx19qkA htiPzJGX5iHBKVEkiWxFLxREAWUJmzj96y+M3Gs+OVM5gXnehr/DkKHz0sc1B+UlONWQ7qFpQh +NGi+1lhhTDKavRpfyy3oByl5b/kW//kz9LaWRUE+iqi4p8Qxzg5K1XsOt7jiL2GOb18OT4CNP ZsU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Apr 30, 2021 at 05:52:11PM +0200, Roger Pau Monne wrote:
> Move the logic from xc_cpu_policy_apply_cpuid into libxl, now that the
> xc_cpu_policy_* helpers allow modifying a cpu policy. By moving such
> parsing into libxl directly we can get rid of xc_xend_cpuid, as libxl
> will now implement it's own private type for storing CPUID
> information, which currently matches xc_xend_cpuid.
> 
> Note the function logic is moved as-is, but requires adapting to the
> libxl coding style.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v2:
>  - Use LOG*D.
>  - Pass a gc to apply_policy.
>  - Use 'r' for libxc return values.
> ---

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.