[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH] xl: constify cmd_table entries


  • To: Julien Grall <julien@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 4 May 2021 16:51:38 +0100
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>
  • Delivery-date: Tue, 04 May 2021 15:51:49 +0000
  • Ironport-hdrordr: A9a23:WG4qNaEfozHxT/fmpLqFOpHXdLJzesId70hD6mlYVQFVfsuEl8 qngfQc0lvOhCwMXWw78OrsBICrSxrnlaJdy48XILukQU3aqHKlRbsSibfK7h/BP2nF9uBb3b p9aKQWMrfNJHVzkMqS2maFOvk6xt3vys6VrMP/61socg1wcaFn6G5Ce2OmO2l7XhNPC5Z8NL f03LslmxOadX4abtu2CxA+NoCum/TxmI/7ehlDPhY76WC15g+A0qLwEBSTw34lIlFy6IolmF KlryXJop+Nntv+4R/a2m/V4f1t6abc4+oGPuOgoIw4Lj3tjyyheYhuXaaT1QpF3N2H2RIRv/ Tn5zsmIsRv+1PdF1vF3ifF6k3b/xsFr1/k1FOCjnPoraXCNUwHIvsEv611WF/9ySMbzbZB+Z MO5U21nd5rKCmFuyLH693BR3hR5zGJiEtnq8E/pThiS4cEAYUhy7A3zQduP7orOjn104wjGP kGNrCn2N9mNWmXaH3UpQBUsaWRd0V2Gh+HR34LsdCO3w5Xm2hkz1AZyNZ3pAZ5yK4A
  • Ironport-sdr: p+MxbggoVgEGUUprX6r7y514u77WP9E30CBgo1VtBj4ZbdaR/vM//zxoDLCg4Q9TE1jG8JRyrK voBq/36UmP+qWXaoQ7p3bV0fCAmuLHcaVB9+N/7OZ1HoZ6A9kFdxdXejeHEE3ZX56OHO2rZYUu NlFIBXQrGBXrCsbhwv/XO6/59hwG76mvTTBFF371KezQIcFesNiaH0XGSnjKtAXTXr+mVjztwy tMPiNvEdLlewGtwDWDY4+e7ObejUYSliX7sW3BJVwN9zVIISbb1UdjmSHbsQnpQ9zHTNpfj/BW 6lQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Apr 28, 2021 at 01:54:39PM +0100, Julien Grall wrote:
> > -int cmdtable_len = sizeof(cmd_table)/sizeof(struct cmd_spec);
> > +const int cmdtable_len = sizeof(cmd_table)/sizeof(struct cmd_spec);
> 
> NIT: This can be replaced with ARRAY_SIZE().

I've thought of using it but the macro isn't available to "xl". But it's
probably a good time to add the macro and start using it.


> 
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.