[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
- To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 4 May 2021 18:47:12 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kS+af/9wuEjAZ5jXY0405C5CYjrYskh69LYhnX2usEg=; b=ceAq+7UuYIit97h5Qbtapee0DE3XvBj2AhC1DTNP9wYJRxsBhSUcH5BLDn7L5MW/Rz5boIbjGu+Wrkgqd/bNqLClvqcBySQiIwMiIhab9wQRVSt8H5aSAPc2o8T1HKUdYS4brwuN6QhTRUtXsDF9lCw1DWSQwyWRwMxYYLNWrNJxgcaTbEPwVYkJjcSxxHp/BH9Ehag2pndGxVgjkiiu8sRdySmAYsEIxscPgosryDh8CCCQcveozoXPpjDt77xBjpd7uKTRfTMxghVtYQNcuOFYUyKBThwmbJlUkaUFiv92/s98OVZEzGjnSIIukm5oA3VqKOgR1Qt7OQBtUiI5Lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIgS6//X48sLEFDEdV6/IzkrbYAy+cEWgENg+HlPh2UrPr7UQTJ8wT2QR1ZEjgyHdEKnkeV9+S/I+ugOtP2OIyOa4v5qAw8XCqriO+rtvHa9i2b74/lfls/DUJiFMv1Xqw249CR5c8GDabVhbahBN8+z7sjImSj44xItbpQMgR8bwFcqeKefVR4M5b6Tk750qLeV39t4yC4piz5zACmF/SWKQo4KVfuweyqEUMAdZNJkyvAZ0MGIITD9XXkbW+XxBRYMXhyGNQCHEn+o4j7uqyPgM9IEs3AauIlG2Bgyvg29IAuRLPrnWYd+YTQHaPnanwl5Z0dgXHf7YM2tXhaeWQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 04 May 2021 17:47:54 +0000
- Ironport-hdrordr: A9a23:0I5MKKEkvtFvuHVopLqFR5TXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7L0/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeOJwTXzcQY76 tpdsFFZOHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLT1CQYsI1XYcNi+wFEpqSA5aQb8wE5 SB7sRKzgDQB0g/RMK9G3UDQqz/vNXNjp3relorABQg5QmIg1qTmcHHOjKf2QoTVC4K/Kc6/Q H+4nDEz4iAk9X+8B/T0GfP849b8eGB9vJvDNGB4/JlUQnEpR2vYO1aKtu/lRAz5Nqi8VM71O TLyi1QQvhbz1P0UiWLrQD22w/muQxemUPK7VODm3PsrYjYaVsBerJ8rLlUeBfY9EYs1esUuM kgshP7xvgneS/opyjz68PFUBtnjCOP0B0fuNUekmBFVs8mYKJRxLZvj399KosKHy7x9ekcYZ BTJfzbjcwmFG+yU2rUpS1GztCqQx0Ib227a3lHkMmU3z9KpWt+3ksVyecO901whK4Vet1q4f /JPb9vk6wLZsgKbbhlDONEesevDHfRKCi8fl66EBDCLuUqKnjNo5n47PEc4/yrQoUByN8XlI 7aWF1VmGYucyvVeIyz9awO1iqIbHS2XDzrxM0bzYN+oKfASL3iNjDGYEwykuO7ys9vQPHzar KWAtZ7EvXjJWzhFcJixAvlQaRfLnEYTYk8pss7YVSTucjGQ7ea9dDzQbL2Hv7AADwkUmTwDj 8oRz7oPvhN6UitRzvWmx7Ud3TxelHu3J55HaTAltJjjLQlB8lpiEw4mF657saEJXlpqaotZn ZzJ7vhj+eaqACNjCH1xlQsHiAYIlde4b3mXX8PjxQNKVnIfbEKvMjaXWhT2XCANyJuVs++Kn 8Ym31HvYaMa7CAzyErDNyqdkiAiWEImX6MR5AA3oqO+NniYZF9Kpo9QqR+GUHqGnVO6EZXgV YGTDVBal7UFzvoh6ngpocTHvvje951hxruB9VVp3LZvUC1vtouWXMfYj6rXaes8EMTbgsRom c0374UgbKGlzrqA3A4mv4EPFpFb3nSPKhLFz2fZIJfmqnifSZ5SWviv03CtzgDPk7Rs2kCjG 3oKiOZPdXGGEBUtHxj3qH2y19sbWmGc0Vsand1jJ1lGQ39ywNO+N7OQpD2/3qaa1MEzO1YCj 3DbDcICi5Fxty81neu6Xu/PERj4q9rEv3WDbwlfb2W52ikL5eQk7oaW9VO+ox+CdzouugXcO 6WdgOPNgnkA+cx1wH9nAd8BABE7F0f1d/40hzs62a1mEMlCf3JOVJ8WvU1Jcqf42WMfYfB7L xJyfYO+c2+PWX6ZoTYleX5bztfJgjSpmDzZecyspxQtb8zsrw2P5Sza0q/6Fh3mDEFaOHznw ciZY4+xpbrEIpmZdYTdCJU5UBBrqXEEGIb9ijNRtYjdlQshULBN9yH47D0uaMia3fx0zfYCB 26yWlh5P/LUCuI6K4CB48xKWpQblIg6H4KxpLKS6TgTCGrffpE5ly0LzuUd6JcUrGMHdwr31 pHyuDNu++cbCzj3g/M+RN9P6JV6m6iBee/GhiFF+IN09u0Pz238+SXyf/2qDf8Uj2gbUsEwa VDaEwLd8xGzgAYs7df6Fn4doXH5mQ/k1Vf5jl7llninqieiV2rbH1uAEn+mZVZXT5aL36Sq9 /KmNLoj0jA3A==
- Ironport-sdr: Xu46TS6FTTbKhTA6PIZWl3g/Un9KqRc3YSfevXA1XMvIHQp21aPrAg/+n8MxS5GSxXZXYA4093 JkB0Hn+iq67NdcG4V0KZ9lho13sEbWGlGTXZerCWFBfqs4mHZeUcEkkBDUP+ow7+PSOduGI0Rc HXObh9YThcFPU4O3KYz8PjbnbiW3+jfvlgGMMhVM/w4AEHGvUyd2ROtlJKiExYA32TgcB/z748 OeB1ypKz7J92XhKBFOhCS6c6/HyaHD/2spGj5eJUm1fJN+I1zDUGLRCSiRTqDtl2cmVeSbPukb p6I=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04/05/2021 14:50, Olaf Hering wrote:
> --log does not take a file, it specifies what is supposed to be logged.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>. That said, ...
> ---
> tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> index ccd5a9b055..36dd717944 100644
> --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
>
> XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
> +#XENCONSOLED_TRACE="none|guest|hv|all"
> #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
It would probably be clearer to untangle these in one go, leaving the
result looking like:
XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
#XENCONSOLED_TRACE="none|guest|hv|all"
XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
#XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
I'd also be tempted to fold this and the NetBSD change together. It's
not as if these bugfixes are distro-specific.
It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into
FreeBSD by c/s 5dcdb2bf569. (P.S. Sorry Roger - both your bugs,
starting from a decade ago). It really is idiotic that we've got a
commonly named *_TRACE variable with totally different semantics for the
two daemons. Then again, its far too late to fix this :(
~Andrew
|
