[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/p2m: please Clang after making certain parts HVM-only


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 5 May 2021 10:01:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9gY0BlSOmYNsZ6Q0USMZWYQt4dTDFkZiNYIdOeG2Ws=; b=oT7dpPlG76HsyDxv/m19TolohsEkqS83rDjYqcOr5/uZxE1HLsfB+wRoXi0hT6fmsFc3UadWjWPdBM49Ilin/jXDLrjuAZOglEpGx9tXoDWP8vir+6tl6iMfW0nzI37h5hm1qN/xDmnB5WcAUQUjYwb4PifthmM+fJad93sT6q8PYpEo7KWV145G0rFi9o3KsF7/pkQwICto2xlhNUg78vch0r0RX4gYw0ebJRbgFOpcA+eBc9ZCwv45cJnuHDGsma39KVw5c0K/kOlPvuK4Jd30ueFJjSW/lxqdGrG60ZzRZq8hld54yQNNRyAvfibzcVD4nSvp8Kom2wK9hg1Lnw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5IxXW0InNJd4AaN4exdlca1FImFOtzxrCm/hNx3ynqIcdjZv/Y+7FaLD92g3aXe3XrKSQjnhPUgICbGeEqlQB7XtvevntA7mIESqLtpIVSlVKGhDZ9xRRroSd7krP0gCezUUbbwItId0FCNaxkkHnuAxE7BAlwH3HQYqDM5j6onWkmZeh0OgGWh8eq5HbkxUyEm/0RtrpkgexJvdufbP2T2n0x9YIJLSHfAyTurjEJmcvXMI0xn9k4Qsij/6GpDH7ZFTaGXezStNEvx2XQL8s5FHlc13/GrSa+UrvVQImS/mlKcju1cnlI73ozYs+dMtitXJ7LcHnfFxMyAX456zw==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Wed, 05 May 2021 08:01:30 +0000
  • Ironport-hdrordr: A9a23:IEe5sqGXYh4gsWBMpLqFWpTXdLJzesId70hD6mlYcjYQWtCEls yogfQQ3QL1jjFUY307hdWcIsC7L0/03aVepa0cJ62rUgWjgmunK4l+8ZDvqgeOJwTXzcQY76 tpdsFFZOHYJURmjMr8/QmzG8shxt7Cy6yzmeLC1R5WLT1CQYsI1XYeNi+wFEpqSA5aQbc4Do Ob/MpbpzymEE5nE/iTLH8DQuTFupn3j5rgexELHFoK7wOJgDOu5tfBYmSl9z0ZVC5CxqpnzH jdn2XCl9+emtyY6juZ7W/c6JxKhMDso+EjOOWggtUYQw+c7zqAS59mX9S5zVQIicGprG0nid zd5yonVv4DlE/5WkGQjV/T1xL70DAogkWSumOwpXf4u8T2SHYbJqN69PpkWyDU4UYho91wuZ gjtwny2us1fHGw6RjV3NTGWwpnkUC5uxMZ4JUupkdSTJcEb/tppZEflXklYKsoJj7w64wsDY BVfbjhzctRGGnqCEzxjy1ExdyhWWkLBRGWQkQOkdz96UkmoFlJi2Qf38ARhXEG6dYUTIRF/f 3NNuBSmKhJVdJ+V9MzOM4xBe+MTkDdSxPFN2yfZXzhCaE8InrI77r6+q886u2GcIEBpaFC1q jpYRd9jyofakjuAcqB0Nlg6RbWWliwWjzr14V3+4V5kqeUfsupDQSzDHQV1+ewqfQWBcPWH9 ypPohNPvPlJWzyXa5UwgzFXYVII3V2arxUhv8LH3a15u7bIIzjseLWNNzJIqD2LDoiUmTjRl QZWjzeI9hB81CLVnf0jAO5YQKpRmXPubZLVITK9ekaz4YAcqdWtBIOtFi/7saXbR1O25ZGOH dWEffCqOeWtGO29WHH4yFCIRxGFHtY573mTjdvrQ8OOEXkTKYbt7ykCCdv9UrCAiU6Y9LdEQ ZZqVgy07mwNYasyScrDM/iFW6GkX0JpjavQ40HkqOOoefpE6lIT6oOaehUL0HmBhZ1kQFlpC NocwkfXHLSETvolOGCl5wbBObWcvFmmwe1KctoqXbS3H/s5/0Hdz8+ZXqDQMSXiQEhS35/nV tq6ZISh7KGhHKSM2cluf85N1dNcWyTJ7pDAG2+FcNps4GuXDs1YXaBhDSchR12Xmbx7U0dil bsKjCudejRDkBQvW1Z1ajW4Ep5H1/tDX5YWzRfi8lQBG7GsnF83auwaq2/33C4R3ECzuseWQ u1Kwc6E0dL/ZSaxRSVkDGNGTEa3Z0oJPXaF6lmWarUwGmRJIqBkrwmE/dY8I1+Ds3ntvYGXI ukClaoBQK9L9ls9x2ep34jNiUxlWItlunw3gb5qEe/x3wyDJPpUR1bboBeB+vZyWfqR/yFis okyf00uPa9KWX3ZJqtz7rNYztKNxPUpiqXQogT2OdplJN3kIE2OZ/RFQbs/jVg+j4VKc/vjk MQQKhh+tn6S8RSVv1XXxgcx0YjkdSEEVAivQP3CNIvZF1FtQ6uA/q5p57z7Yc1CkKPpAHMKU CS3i1U8fDCRTaC39chetQNCFUTTEg383J5+uyeM6XWFQWxbulGlWDKf0OVQft4SKKfH68XoQ s/y9aUn/WPfy69/AzLpzN0LuZv9GmgKPnCTD6kKKpt89agP06LjbbvyMmvjC3vQT/+Un8mv+ R+BAQtR/UGrCIjgo0x2jWzTaKygntNqSoh3RhX0nj32oan52/HG1phKgOxuOQPYQVu
  • Ironport-sdr: PTho5+iTmy5MtKq9ynOtufHZtKEPo54/U3bo2URdiEblnpiBbsVzD64LqJwkhXhS4hCUprsNtK BD09icODCz+0kFWCKK3KYDWTD5dtICNN52F4gEz0qCpYKpgVh5HWvXJxxR9h/VxxSGrDn9HJyD OS+QZyXGnKksIIJ5IGDcV4frGAd69WvfwDyWsSjKNzEpMou5jo+Wm76EkpM3/tp9ceNH1k1RlP w5gXVjKJn+8b5x0WnYUJNGDB+Z6JzIlZjnbHeGy1NHoTQjErjtlElYC9kPgsfOCeNVkRNa9eh4 2KY=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, May 05, 2021 at 09:07:30AM +0200, Jan Beulich wrote:
> Move a few #ifdef-s, to account for diagnostics like
> 
> p2m.c:549:1: error: non-void function does not return a value in all control 
> paths [-Werror,-Wreturn-type]

There's also __builtin_unreachable, but that would get even messier,
and I'm not sure it's supported by all gcc versions we care about.

> which appear despite paging_mode_translate() resolving to constant
> "false" when !HVM. All of the affected functions are intended to become
> fully HVM-only anyway, with their non-translated stub handling split off
> elsewhere.
> 
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Fixes: 8d012d3ddffc ("x86/p2m: {get,set}_entry hooks and p2m-pt.c are 
> HVM-only")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.