Re: [PATCH v3 03/10] arm: Modify type of actlr to register_t

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 05/05/2021 08:43, Michal Orzel wrote:
> AArch64 registers are 64bit whereas AArch32 registers
> are 32bit or 64bit. MSR/MRS are expecting 64bit values thus
> we should get rid of helpers READ/WRITE_SYSREG32
> in favour of using READ/WRITE_SYSREG.
> We should also use register_t type when reading sysregs
> which can correspond to uint64_t or uint32_t.
> Even though many AArch64 registers have upper 32bit reserved
> it does not mean that they can't be widen in the future.
>
> ACTLR_EL1 system register bits are implementation defined
> which means it is possibly a latent bug on current HW as the CPU
> implementer may already have decided to use the top 32bit.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
This patch will want to be backported.

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall