[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/13] libs/guest: make a cpu policy compatible with older Xen versions
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 6 May 2021 12:23:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xZfjdiCL9zYhnCF7SZwghC1t18RKGyGWZ8vorFpFRZ0=; b=GUg1WpeXoBR9cwMicQmaNRyJa02IjvZeOV6oxLy1ys2iNsLYiMFDjRelBOru9u9Bduh7wQeTXk/PEaUua1pgI2lPQxR1UISAhpQDReB9tQsmbmyPYco8vgKp+lxrk0d0XiP0L9sNwPH1sbnzGteAVulvzC2/u6VTM6xjOI2tUguu0lbmnseUD9VqBW0Fgk941j/+QT4n99fj7dQPLCJX9VYFF+YDuoWIojPirki7B1hDQfTb+/zfICRp153Rw+XS5syRjG0BiGjrQccVDn9tdmlDyJqUuu6yl2X3fcz4cB5FnQlpWGEBkTSPATgZTa5eEFWMzQlC/wFOOvqWHNGYqA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PykVm8fUOc5EQC4hppjmTZ2sjd7VPszm3doGXRsCktivccxxt6/3nViNVa1PSgOjAceyswyZAFYvVDJCYu1EjZ0MTmVxlqVEw52Y/Y0bcxmabNI3VTdlVkFljna8dDup4QwsyqnccAVs5oegJkjkyRG8+ss8zDuHNbHnS1hbebl4+hpru0Lk8if9U6KRT3mrveis+v/TvPYW/vhmGvjWALJRN2dmqc7OApMiFZgfvD0Yl6JgEcUHVJb6GFpPaJ4U6MouhDz9SxLjrd+gc+3sHuHQbhmg+1xyVvd7Qntw0UCR8k8fVeWBKUoLbS5zYxbe9U8sX+++nkTJARJ8bu4YWQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 06 May 2021 10:23:22 +0000
- Ironport-hdrordr: A9a23:YTAtzqBki+RBoNTlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- Ironport-sdr: VhcAWxrdNIb6W70kTGWbftLSM4EbW5szUNIzdAKr5Cay48ZtHk/hiPZDOseh6ZrOsLtGqttsyv PZ4NpiYuV/C5aas8eEFJDgnRZao8bSqmbTCS79sa6OwX5+Apiyh+k4MLmX5npKxueSxDR7FG0a 7Sv9D7Cn4IuK99ahhyMkIeokkJl/5DDDnPeIpI/wnnVNR0dbGoVZHFy3brpkxU3RHZOr8U9Bqu OtrK5XJA4cM839TofHstciohayfXxHeUkeKJ934n8tKGq3ginuxLcVW5LFoeHlKIdu97ofSopz 1mk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 05, 2021 at 09:42:09AM +0200, Jan Beulich wrote:
> On 04.05.2021 17:34, Roger Pau Monné wrote:
> > On Mon, May 03, 2021 at 01:09:41PM +0200, Jan Beulich wrote:
> >> On 30.04.2021 17:52, Roger Pau Monne wrote:
> >>> @@ -1086,3 +1075,42 @@ int xc_cpu_policy_calc_compatible(xc_interface
> >>> *xch,
> >>>
> >>> return rc;
> >>> }
> >>> +
> >>> +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t
> >>> policy,
> >>> + bool hvm)
> >>
> >> I'm concerned of the naming, and in particular the two very different
> >> meanings of "compatible" for xc_cpu_policy_calc_compatible() and this
> >> new one. I'm afraid I don't have a good suggestion though, short of
> >> making the name even longer and inserting "backwards".
> >
> > Would xc_cpu_policy_make_compat_412 be acceptable?
> >
> > That's the more concise one I can think of.
>
> Hmm, maybe (perhaps with an underscore inserted between 4 and 12). Yet
> (sorry) a comment in the function says "since Xen 4.13", which includes
> changes that have happened later. Therefore it's not really clear to me
> whether the function really _only_ deals with the 4.12 / 4.13 boundary.
It should deal with any changes in the default cpuid policy that
happened after (and not including) Xen 4.12. So resulting policy is
compatible with the behaviour that Xen 4.12 had. Any changes made in
Xen 4.13 and further versions should be accounted for here.
Thanks, Roger.
|
