[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] tools: fix incorrect suggestions for XENCONSOLED_TRACE on BSD


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Thu, 6 May 2021 17:17:01 +0200
  • Arc-authentication-results: i=1; strato.com; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1620314224; s=strato-dkim-0002; d=strato.com; h=Message-Id:Date:Subject:Cc:To:From:Cc:Date:From:Subject:Sender; bh=FxbKl46WH8hAOJ0YzhvXx5JTFJunhpUurX0R/y8sMCM=; b=n4RcCjDeJT4MUegPYhnoe33gScGt1iZ7ZgT1IV+d0WUJ6VRwUAFH4pUXEI6+J7nP1D k0UU6HprK5QfzUM2fSMqzsmWIvxE0WPpsKmfvuqeqI1Ey0vwktAS1+gkkMLNRi5P93N6 bA4xdQxwHwCPDIFQmn/SLvCe0GJPNzlSBPn3JQBI+Y9+LY5Xzkm+KMijuD7K/XhOog6l YHN3HeU4NnbYrqcVf/XMGoO/WlhXSaXnvuiwgBdfsfPbnMVrdwbDmBNX7hwi70wxUqGX MumLi5423GUqRisI7b4mVFl2ib+DfCN+I+xFs/jBgsbG0HYkuvUU+yTHWqOE/NwKWZmu 6r/w==
  • Arc-seal: i=1; a=rsa-sha256; t=1620314224; cv=none; d=strato.com; s=strato-dkim-0002; b=jzBcN2Rmupd0W1QlGCEEpZOie/G31WOdExFfoQkC6A76xEpCKg0NsM0Pweb3BoLzfR eeQVeYDOffC4ES1tGNOVo5hqZm8W61qforXkhiNas4YiHvKlB7PLnn3NhLNiiwWsLPIp ORGeW/jUT4AkVesZ4oBWoapAEYg59L2s6j9dRMKadDtnZQOjWb5BLGMXmbKmEalDdPDk z3F76UX2QWmMo3w1QXi0exAI0w6MBT89nfRprs7vQRCZ+geVup5kam/iaRUZyUx2vp4R N2ahidKBKorLJc0PdQxEsUuyzuxG8covtAUuOCVipqLl6ApRyPShJAGVMUe9RDF/yEDu hutg==
  • Authentication-results: strato.com; dkim=none
  • Cc: Olaf Hering <olaf@xxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 06 May 2021 15:17:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

--log does not take a file, it specifies what is supposed to be logged.

Also separate the XENSTORED and XENCONSOLED variables by a newline.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
---
 tools/hotplug/FreeBSD/rc.d/xencommons.in | 5 +++--
 tools/hotplug/NetBSD/rc.d/xencommons.in  | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in 
b/tools/hotplug/FreeBSD/rc.d/xencommons.in
index ccd5a9b055..4c61d8c94e 100644
--- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
+++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
@@ -21,9 +21,10 @@ status_cmd="xen_status"
 extra_commands="status"
 required_files="/dev/xen/xenstored"
 
-XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
+#XENCONSOLED_TRACE="none|guest|hv|all"
+
+XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
 
 load_rc_config $name
diff --git a/tools/hotplug/NetBSD/rc.d/xencommons.in 
b/tools/hotplug/NetBSD/rc.d/xencommons.in
index 3981787eac..80e518f5de 100644
--- a/tools/hotplug/NetBSD/rc.d/xencommons.in
+++ b/tools/hotplug/NetBSD/rc.d/xencommons.in
@@ -20,9 +20,10 @@ status_cmd="xen_status"
 extra_commands="status"
 required_files="/kern/xen/privcmd"
 
-XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
+#XENCONSOLED_TRACE="none|guest|hv|all"
+
+XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 #XENSTORED_TRACE="@XEN_LOG_DIR@/xenstore-trace.log"
 
 xen_precmd()



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.