[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

PING Re: [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel

On 18/04/2021 19:26, Julien Grall wrote:
On 12/04/2021 07:45, Michal Orzel wrote:
On 06.04.2021 21:15, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

Currently, we are ignoring any error from perform_gunzip() and replacing
the compressed kernel with the "uncompressed" kernel.

If there is a gzip failure, then it means that the output buffer may
contain garbagge. So it can result to various sort of behavior that may
be difficult to root cause.

In case of failure, free the output buffer and propagate the error.
We also need to adjust the return check for kernel_compress() as
perform_gunzip() may return a positive value.

Take the opportunity to adjust the code style for the check.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

     Changes in v2:
         - Fix build

Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

Thanks! @Stefano, can I get your acked-by?

Ping? I intend to commit it on Wednesday unless I hear otherwise.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.