[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen-netback: Check for hotplug-status existence before watching



On 10/05/2021 19:53, Marek Marczykowski-Górecki wrote:
On Mon, May 10, 2021 at 07:47:01PM +0100, Michael Brown wrote:
That doesn't sound plausible to me.  In the setup as you describe, how is
the kernel expected to differentiate between "hotplug script has not yet
created the node" and "hotplug script does not exist and will therefore
never create any node"?

Is the later valid at all? From what I can see in the toolstack, it
always sets some hotplug script (if not specified explicitly - then
"vif-bridge"),

I don't see any definitive documentation around that so I can't answer for sure. It's probably best to let one of the Xen guys answer that.

If you have a suggested patch, I'm happy to test that it doesn't reintroduce the regression bug that was fixed by this commit.

Michael



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.