[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/14] tools/top: The string parameter in set_prompt() and set_delay() should be const


  • To: Julien Grall <julien@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 11 May 2021 16:46:04 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 11 May 2021 15:46:11 +0000
  • Ironport-hdrordr: A9a23:95EH3KrANCyAMtaAs6bRfuEaV5oreYIsimQD101hICG8cqSj+f xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U 4JSdkZNDSaNzlHZKjBjzWFLw==
  • Ironport-sdr: 0Vm+3RgCcX1GTvoz669DkBeiZmbA6rbzmSJgLHRgkUcN4hCFVpqQm4XB/BTQWhXzGSIQhHQqBF gajVUHTBRzZdWzOFRMrWImSXyROvjyt0x52oEBkCnZaZWmFSZO5yOf/J8c33EvANMWeVqv6EB1 hdtFH6534k6xd2igpJCvREPBB+nYrwvPdFtnVBZ3K+7eaNNibEoSJIV0jsT7jRPuQgn0iz4pUE uTziQaqNjtoededmqZ0rM6F8/aI/TGXGHLVXkespZX4EVBskDAzD9vq1zsA2Mup2cVd2KeMzjf Sko=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Apr 05, 2021 at 04:57:11PM +0100, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Neither string parameter in set_prompt() and set_delay() are meant to
> be modified. In particular, new_prompt can point to a literal string.
> 
> So mark the two parameters as const and propagate it.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.