[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 00/17] live update and gnttab patches

  • To: Edwin Török <edvin.torok@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 11 May 2021 21:05:38 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yHSqoKI0B0vWUlCCXnk3zGPds3/b7z3KLLtbZlG9J6g=; b=CrgGpIpScjiFXzMPQLktQXGYM1a59nUQHhNZSdWFGLJV0m8CypmoY3Bcdedhtrg1L42+pkWLZNavf7cAE82hYJPb9FQBNqXFDNvhOEIykrcILHQY9LARmsifhP7BTTFqXl76o2cNZzMnaHFIbNGkgZd4JcmOXmKJx+ZPvMZsDUohcLYCgcalmilIL0lZWe+sCm7Izzyqbk4Olm5eGNNRs3tHvn1NiMayOMtfNpe46xtf0yEwOacukzm6bUPur1vAqcZiP9z3vaW8xp74VnO2vqK4G1Ubkw2XliKXH0Q9qPo/ii9PGos0g8UBZj4lqlEFye26CQBzvw2b5mPf9S6f3Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HAp0LVwOF2zA3KXJv35cgF3cG1N+FcfTnhtx98XLLqX04RsSJSyLGKW4C2sIzCajlEtqdAHvmwq+3a+pJvbnZnnic15CHkgNKFG6rgFaKuDENuMwRGejFgkctAx4V+osY/LtUQtq2W43ZrWjTn1ogFChh9x5IaoIlghI4mN1g4be+1kNQvvjCGTMmtInRF04t48BLZCKfny7DWgN8Djhw0ssM22kVVnA/b8WcTid/a0YSfUSedqKhz2w+br2FcK/plyH4BZGHsCjZP0bQcOUyywZFWfX2h5nyS7BrfShAcaJkTCxqshw9LmIXcAqzEmHj34XWSmczREQIh7Lk7D5ZQ==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 11 May 2021 20:06:02 +0000
  • Ironport-hdrordr: A9a23:8iN59ampt0WtjyYWhQHG6DJ8zEvpDfKt3DAbv31ZSRFFG/Fwz/ re5cjzpiWE8Ar5OUtQ5+xoV5PwJE80maQa3WBVB8bFYOCEghrYEGgB1/qH/9SIIUSXnYQxuc hdmupFebrN5DNB7foSlTPIcerIt+P3k5xA692+85+wJTsaG52IpD0JcTpzWncGPjVuNN4BD5 yb6dNApz28PVoqTunTPAh2Y8Hz4+TRkpToeBgHAANizjKvo3eH1J7WeiLorSv3dVt0sMMfGK z+4nnEz7Tmuaqj0RnX23XI45lRg9WJ8Ko9OCRO5/JlVgkEpDzYGbhcZw==
  • Ironport-sdr: yQtaLk/ETNQNmOdso3w9OI4fw+t+D9nsqG83DqJSP+8QO81WhzAAlXUJ/x5rA2J6oI/HmQnjWf BSXZyk51XPCSXcNv69UIBJNRg+PRQ4XRqeQLt3SZIQK2B3V1XBqYDeyPvYTt1OXvbIT2hFsSz1 htv+HC1Yize1WceygelYs8PeOARcpnD6SyQ5A2bHPLZcTDSPgvdPqhw3BE2cV2rMtjT0gCtVyo sN38GJ7e8/87wTp6eZsftbVGUotrjB1bulas1HeiQpjKqZn1JmEFp0RAWjYj1gMyzoiPH4m4Ab 1n8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/05/2021 19:05, Edwin Török wrote:
> These patches have been posted previously.
> The gnttab patches (tools/ocaml/libs/mmap) were not applied at the time
> to avoid conflicts with an in-progress XSA.
> The binary format live-update and fuzzing patches were not applied
> because it was too close to the next Xen release freeze.
> The patches depend on each-other: live-update only works correctly when the 
> gnttab
> patches are taken too (MFN is not part of the binary live-update stream),
> so they are included here as a single series.
> The gnttab patches replaces one use of libxenctrl with stable interfaces, 
> leaving one unstable
> libxenctrl interface used by oxenstored.
> The 'vendor external dependencies' may be optional, it is useful to be part
> of a patchqueue in a specfile so that you can build everything without 
> external dependencies,
> but might as well commit it so everyone has it easily available not just 
> XenServer.
> Note that the live-update fuzz test doesn't yet pass, it is still able to 
> find bugs.
> However the reduced version with a fixed seed used as a unit test does pass,
> so it is useful to have it committed, and further improvements can be made 
> later
> as more bugs are discovered and fixed.
> Edwin Török (17):
>   docs/designs/xenstore-migration.md: clarify that deletes are recursive
>   tools/ocaml: add unit test skeleton with Dune build system
>   tools/ocaml: vendor external dependencies for convenience
>   tools/ocaml/xenstored: implement the live migration binary format
>   tools/ocaml/xenstored: add binary dump format support
>   tools/ocaml/xenstored: add support for binary format
>   tools/ocaml/xenstored: validate config file before live update
>   Add structured fuzzing unit test
>   tools/ocaml: use common macros for manipulating mmap_interface
>   tools/ocaml/libs/mmap: allocate correct number of bytes
>   tools/ocaml/libs/mmap: Expose stub_mmap_alloc
>   tools/ocaml/libs/mmap: mark mmap/munmap as blocking
>   tools/ocaml/libs/xb: import gnttab stubs from mirage
>   tools/ocaml: safer Xenmmap interface
>   tools/ocaml/xenstored: use gnttab instead of xenctrl's
>     foreign_map_range
>   tools/ocaml/xenstored: don't store domU's mfn of ring page
>   tools/ocaml/libs/mmap: Clean up unused read/write

Gitlab CI reports failures across the board in Debian Stretch 32-bit
builds.  All logs
https://gitlab.com/xen-project/patchew/xen/-/pipelines/301146112 but the
tl;dr seems to be:

File "disk.ml", line 179, characters 26-37:
Error: Integer literal exceeds the range of representable integers of
type int




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.