[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 17/17] tools/ocaml/libs/mmap: Clean up unused read/write
- To: Edwin Török <edvin.torok@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 12 May 2021 14:06:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5QAeRcH2yITfeyIVLS3SF+CzQZKrd9W57cayGjn8adI=; b=buWJLVNq9TdtgD4+eOqft8qRY3mOCHwm/ICESp0Rrzf9JtkuuoL6zJ1P+2lD3gx6SnlKBlDZYIlxEive3Jt6XSfUVzxTLQCH25uHrvzr7iG1H6v92Jjnzc0HjWi4p12vDttbSrdGmjFiWPect2Pq245KTH9NAfujJmSooB4nBjSPZF1suUY2gsy617fsnRlEiegg8MEYf9cc396pHnMGbgvd5Nh9x7khPZ0jNCm8Ot0dn5iZ6YW27QNIjCfmc7dLafbgDHFymvDd6zdSEl/KY4LRqrbsyM7W8BfpJ0/vBhsmleXoXPf1accytujA2FakvjeZMO95PsrXtxV6PD3UNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIjrsGlmcr8FeowPECAKadvy2ImM3wgtpWdkEjauM23Jfg1iF/ZK4Dc9zgYOps+Ka0B3c3zp6XJJyrMg41ehZ+kLwxU0ofKAN0Okh4chbGZCK+hbOdqQd/hF2d1yaIRG42PyYInAx/+UkwXTRKacYDT84Mp42kzKJJkDHyoE0n5yYoVXDJ3jR1Qb7ToeLyjICF+iJbyOIoHfuCzte7Te5Bz7Qv9c3IUPsxnUKSPlBFgS5CwQxxegSfohSSlTc24hdeugD4LwdbDcRED5GzrUZsf/259iZCinaOaS33QTo2cfyzUexpX+m2lzKINmUqL1ZSSeOIFzP0ijawHjahqFKg==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 12 May 2021 13:06:43 +0000
- Ironport-hdrordr: A9a23:FxUuR6l6aZYFygJ62JXgJEdYVBrpDfIs3DAbv31ZSRFFG/Fwwf rAoB19726RtN9xYgBEpTnkAsK9qBznhP1ICOUqXItKPzOJhILLFvAE0WKK+VSJcUDDH4VmpM VdmsZFaOEYJGIXsS6wiDPIdeod/A==
- Ironport-sdr: j7qRNONbHY4OnoRkAW0WQdBnI+IW+Pqt06UVbVjKiGf2RuLn4fncgZAsbtqH/jp2FGYsEw4W0c vvvYcc1PZ4YPPPoltukwlDyg6kiX3qxa4xdY22D3r++3Ejm/dR4nGS+tdM3amt3rMgeQVcMm3j vOV8d8zFyJBnR8Q/9Fi1sCmx9NX1p1YBwoL3/Yo7Ig6+R2rh8hnMeh2xPYBt8rhOqr70R7KJPL zbnFo8XjsjRbPhVqqe76zW/EpK0tR8qp9y8LhfdOXYPmcIUpRAxLQa5BbOIIrG4DUSEd4GrusX /+U=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/05/2021 19:05, Edwin Török wrote:
> diff --git a/tools/ocaml/libs/mmap/xenmmap.ml
> b/tools/ocaml/libs/mmap/xenmmap.ml
> index af258942a0..e17a62e607 100644
> --- a/tools/ocaml/libs/mmap/xenmmap.ml
> +++ b/tools/ocaml/libs/mmap/xenmmap.ml
> @@ -24,11 +24,6 @@ type mmap_map_flag = SHARED | PRIVATE
> (* mmap: fd -> prot_flag -> map_flag -> length -> offset -> interface *)
> external mmap': Unix.file_descr -> mmap_prot_flag -> mmap_map_flag
> -> int -> int -> mmap_interface = "stub_mmap_init"
> -(* read: interface -> start -> length -> data *)
> -external read: mmap_interface -> int -> int -> string = "stub_mmap_read"
> -(* write: interface -> data -> start -> length -> unit *)
> -external write: mmap_interface -> string -> int -> int -> unit =
> "stub_mmap_write"
> -(* getpagesize: unit -> size of page *)
> external unmap': mmap_interface -> unit = "stub_mmap_final"
> (* getpagesize: unit -> size of page *)
> let make ?(unmap=unmap') interface = interface, unmap
Are comments supposed to be above or below the declaration? The double
getpagesize and missing unmap comment looks like a copy&paste mistake in
the past.
~Andrew
|
