[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 09/10] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 14 May 2021 11:36:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oFY+P0vCHwC1ZGQbL3Mljf4Z3Nq0ZT0Q6qIFdYRgqhg=; b=bjokIZjubOsJn+uzI1on0p3sySymg4/5dtQMo1EwSU90ZPAd82CPRYfp0gfb5ERCjmHrV27TBY/OLlmdoxTcE5r0skUVUUH7LfJmNyJDR7Y1o4fzELeQk7jND+ay74/Ttf+U1r28+Ni1CTErAJKxcbZNRLLSC/rcI04ViV0ZZ4c2/R4KSkGbj7FNySp8KExdyH9jHq/EaZmW7U/6wrTEvadMMy6IKi+fUcTjRzUGQq/6CFtvlw4RZXf3600SiVs32IlViOtrgIdxFZ+2D67Xwh7phRqwb0vvdjSFuJhhKK4EOL3WhZ2o8uqMN1K9QkFSYxr29g/N0h8ml8Sh1L3EBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jSZQ2OLuLkBBylV1GiY+djKviXf7avekLXJslaRcfsTI33g6Xsnf3DcWal1NI6BylSIQjFNwzq9Yg1066ABno/4jBfw/LnLd+V9M3aA7Fj+SxFQHf5bEZgLlm1bmj2q07pr30Tf9uJ+s6RKK+pyca1sN2twr9xl1YrrtZjFK831Sq7mH/5npbeKVhpMotuwL86t72RjONLjJSSzCVm8K8KrWZbxD0wwOxUuFuMUDX1+J9CPCDjfvB1uOPXcUdffX9ODN55MEq6yfNaYe8JPRdQHrNSge9wjQXNL+YUTbEQlI01zLlyKaYSZVDFGUVWRk6ljAmN+l9x/1vXKyyBxYpQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Fri, 14 May 2021 09:36:27 +0000
- Ironport-hdrordr: A9a23:vilYsa0Sc56uNSvGFv9x3AqjBbByeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJ0800aQFnLX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79 YdT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY55at854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH LKjfA32QZINE5nIvhSaRI+Lqf+juyOsKijTQ8NBhYh5gXLpyiv8qTGHx+R2Qpbey9TwJ85mF K10zDR1+GGibWW2xXc32jc49B9g9360OZOA8SKl4w8NijssAC1f45sMofy/QzdmNvfqmrCre O85ivJZ69ImjfslyCO0FXQMjDboXUTAySI8y7evZOLyvaJNw7TCKJ69Mlkm1XimgwdVHwV6t M844ujjesiMfr3plW02zH5bWAeqqOKmwtUrQcytQ0UbWJMUs4dkWQglHklWavoSxiKl7zPVt MeVf3h2A==
- Ironport-sdr: 2HR/JhpxVyPlBjBUFruYbJ84y5Ju5BB8pK+YQHptqraxqJc1GQtlm7yTaM2s64zFZWl0Lh+hOS RrpDhnaUpuA/B+5vsAwUaPgzPFUjSNmA4jrW/h6ehh2bS6obsXoEXQS/9mFKaLZDkekhW6BTYJ g2F1tdrJspkBUKV1PdesTmP0hqbSvsxZTPfXXXABNN9rLE6F1x/LpCmn9YkshtSaCYRquEbQ15 rN9TqAChn86zEixlDuLNYKgdEVPpgNBgU8wYU/m607eXOepIHBLBiV1HK+HMLeU4jdUfRttETe l/M=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, May 07, 2021 at 01:04:21PM +0200, Roger Pau Monne wrote:
> diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
> index eb6feaa96d1..6d17e89191f 100644
> --- a/tools/libs/light/libxl_cpuid.c
> +++ b/tools/libs/light/libxl_cpuid.c
> @@ -430,9 +430,11 @@ int libxl__cpuid_legacy(libxl_ctx *ctx, uint32_t domid,
> bool restore,
> libxl_domain_build_info *info)
> {
> GC_INIT(ctx);
> + xc_cpu_policy_t *policy = NULL;
> + bool hvm = info->type == LIBXL_DOMAIN_TYPE_HVM;
This is wrong and should instead be:
bool hvm = info->type != LIBXL_DOMAIN_TYPE_PV;
To account for libxl having a different domain type for PVH. I've
fixed it on my local copy of the patch.
Maybe the variable should also have a different name? I really cannot
think of any other name short of 'translated' or hvm_container. Let me
know if I should change the variable name.
Roger.
|
