Re: [PATCH v3 2/2] libelf: improve PVH elfnote parsing

[Jan Beulich <jbeulich@xxxxxxxx>]

On 20.05.2021 14:30, Roger Pau Monne wrote:
> Pass an hvm boolean parameter to the elf note parsing and checking
> routines, so that better checking can be done in case libelf is
> dealing with an hvm container.
> 
> elf_xen_note_check shouldn't return early unless PHYS32_ENTRY is set
> and the container is of type HVM, or else the loader and version
> checks would be avoided for kernels intended to be booted as PV but
> that also have PHYS32_ENTRY set.
> 
> Adjust elf_xen_addr_calc_check so that the virtual addresses are
> actually physical ones (by setting virt_base and elf_paddr_offset to
> zero) when the container is of type HVM, as that container is always
> started with paging disabled.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

With the one hunk moved to patch 1
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan