[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP


  • To: Juergen Gross <jgross@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Fri, 21 May 2021 09:12:29 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pd9iADF2AoIYmkR0KCUndINvq5YCd1FizfhYJYGi53k=; b=Khb+sFqwJ2BBvvOR0AOlDjP/xr3bYBf1XQQ0oOuhqU32vpb5zbEWLNl2dK4NRyEUfuV+zvpg7FDEwt+/9ZZEIk8ND0gR68QBv6sblzQAgQn0B6q6cSc2AHWmS2EA3t8r9rmbA6Ff3H7wu/QfPqlkgw+bDBSBKgnrafDk1O4D+E/NW1b2x8IBVu0CzNGCt6KIP3xcMJBm9nvEILGpuTlIsoyp8SOtYB2rXegdrziP88CXuG7PHbs9uKwqkndlZ3OBsiE5Zx8yDpMlWBDw3mZA3EbCXnxKK3uAOJlt605F2esBdWrNEMn4wMD22u7J9q9/IrCFTaMhBomwVmFH9Y6NFQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AunWRNxw+GgLTv7G2G8CP+iuTlwI1B929+4rzwnEQOssM1eyTNIAItZlHylO+yahhh+0ZNf31ke9OPp7Yo3biVVlvnqkegQZNjwpi7r6WXi8pFpp3dFADt03/mdN8AFlve6V7cpW2kL/6ZtD61uxBRbptyKjC3cat2VtgnQ4b2LirPwZDIMHWeHu9FMyRByjaCJAVbVo1WFBvCxMdKmLGmLqdrbENYcyIP8p9aHuMXDsG+ykc1Mo/UPEdefHPwlAUK4DO00k486M8VVi3ghMMNkLEGtq161DXOtP+g1U5GW9hJpUYOD0KhfvU5hlxpmSNXiZz/1ppPlcHefEKm7jgg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=oracle.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 21 May 2021 13:13:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 5/21/21 3:45 AM, Juergen Gross wrote:
> On 21.05.21 09:26, Jan Beulich wrote:
>> On 21.05.2021 09:18, Juergen Gross wrote:
>>> On 20.05.21 14:08, Jan Beulich wrote:
>>>> On 20.05.2021 13:57, Juergen Gross wrote:
>>>>> On 20.05.21 13:42, Jan Beulich wrote:
>>>>>> xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables.
>>>>>> For this to work when NX is not available, x86_configure_nx() needs 
> to
>>>>>> be called first.
>>>>>>
>>>>>> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
>>>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>>>>
>>>>> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>>>>
>>>> Thanks. I guess I forgot
>>>>
>>>> Cc: stable@xxxxxxxxxxxxxxx
>>>>
>>>> If you agree, can you please add this before pushing to Linus?
>>>
>>> Uh, just had a look why x86_configure_nx() was called after
>>> xen_setup_gdt().
>>>
>>> Upstream your patch will be fine, but before kernel 5.9 it will
>>> break running as 32-bit PV guest (see commit 36104cb9012a82e7).
>>
>> Oh, indeed. That commit then actually introduced the issue here,
>> and hence a Fixes: tag may be warranted.
>
> Added it already. :-)
>
> And I've limited the backport to happen not for 5.8 and older, of
> course.


Did something changed recently that this became a problem? That commit has been 
there for 3 years.


Didn't Olaf report this to be a problem only on SLES kernels?



-boris




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.