[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 2/4] xen/common: Guard iommu symbols with CONFIG_HAS_PASSTHROUGH

On 24.05.2021 16:34, Connor Davis wrote:
> The variables iommu_enabled and iommu_dont_flush_iotlb are defined in
> drivers/passthrough/iommu.c and are referenced in common code, which
> causes the link to fail when !CONFIG_HAS_PASSTHROUGH.
> Guard references to these variables in common code so that xen
> Signed-off-by: Connor Davis <connojdavis@xxxxxxxxx>

Somewhat hesitantly
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with ...

> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -51,9 +51,15 @@ static inline bool_t dfn_eq(dfn_t x, dfn_t y)
>      return dfn_x(x) == dfn_x(y);
>  }
> -extern bool_t iommu_enable, iommu_enabled;
> +extern bool_t iommu_enable;

... just "bool" used here, as I think I did say before. Can be taken
care of while committing, I think.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.