[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] firmware/shim: UNSUPPORTED=n
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 25 May 2021 16:39:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZTtDCpKb95BElI2EcWwLmQFoRxCis1zJsMHVmCRsnOA=; b=E8e+8jG16/ORcWQMvq+GMM35hQJNXdFzXNZmO+lgd3hhlk+roZhJ8+SyolE+o5kVPUszYwEJkSKKp1HNz6lmrAeQ6239kbE7tSjqrTD4rBtNow8fGGTkpBXXr+HSfXUA5BAO4sK41QZWUPgWQ7+nhQLdiAS3TI0xOu6Ng++4XRucRYnPFT8LGQWByEbB/v5NCeBMCfP2WXOah/3suG1FT3W5QuMtvKnIpgpp/Dd2R/EiNnFTfsFKxDIssHWBsg7YRDsPPTdsWfAE8CPqGBRn0pq3vGUIUcrFXo3ti0g5fO41GhaTFe+kwxV0E1eFqPo91Npb1tT3i2VbTES5dheh8Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edU7RWTAZmpw0NfP2H5HAQFr6tF4DGe9vRAn16Q18Gb5RRA13bPd4k5hTHMkdSuZ2E/xBRcKQ/kN871mD0eAoUl2x8TS9S2P+EUQyhF3YtMQx/OMcjtLOSpbUO8z8e3/zTzqM9YEfII9olAMo+2ykBqkCO/0Qq+MF3YwNSiHibaTRAGQbhSEY4beyVhQcfakaQP6Ecf+TrNnwvyLJZjfCFeABKnP7JJud6tw6VyO7TxxBUmRKy0cFJgFdblEka1dz24z7Jcdj6InSPtYjIy+QNExPCMEJRqygwTEK+QH/IlihJRDGlZQ/L6tvsO6WHcrrWL3qWAFP+vEFC2FvuWFTA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "George Dunlap" <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>
- Delivery-date: Tue, 25 May 2021 14:39:27 +0000
- Ironport-data: A9a23:GRmvBqIJINukt6goFE+RzpUlxSXFcZb7ZxGr2PjKsXjdYENSg2QEn GRLWj3Xbq7eY2OhLtl1Po/n/UwB7cXdx4VnSQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0zrbf65xZVF/fngqoDUUYYoAQgsA18+IMsdoUg7wbdh39Q12YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 O4W5cOQURV1BajjgchMAzhGKAJiO5QTrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne16TsmdpXScE17ignBNPsM44F/Glp0BnSDOo8QICFSKLPjTNd9Gts254VRKaAD yYfQRAwZx+QUSF/BkYGAbsDg7mnjWDZIiIN/Tp5ooJoujOOnWSdyoPFMtDYZ9iLTsV9hVuDq yTN+GGRKgEXMpmTxCSI9lqoh/TThmXrVYQKDrq6+/V2xlqJyQQ7Fxk+RVa95/6jhSaWWs1dA 1wZ/DI0qqo//1DtScPyNzWju2KNtBMYX9tWEsU55RuLx66S5ByWbkAIQDdOZ90hsM4eXiEx2 xmCmNaBONB0mOTLEzTHrO7S9G7if3JMRYMfWcMaZTBes4bDuJNvtRfgV/oyQI+rtf7pHwill lhmsxMCa6UvYd8jjvvhpAGd2Wz9+PAlXSZvuFyMAT7NAhdRId79PtL4tTA3+N4ddN7xc7WXg JQTdyFyBsggCouR3AiEXekABr2g4/vt3Nb02gU0RsBJG9hA4ReekWFsDNNWfx0B3iUsI2WBj KrvVeR5vsE7AZdSRfUrC79d8uxzpUQaKTgAahwzRoAeCqWdiSfeo3A0DaJu9zuFfLcQfVEXZ s7ALJfE4YcyIqV71jumL9rxIpdxmnhW+I8nfrimn0XP+efPPxa9FOZaWGZim8hktctoVi2Oq I0BXyZLoj0CONDDjt7/od9LcQ9SdSBlbX00wuQOHtO+zsNdMDhJI9fawK87epwjmKJQl+zS+ Wq6VFMew1367UAr4y3TApy/QNsDhapCkE8=
- Ironport-hdrordr: A9a23:nhfjLK/j+/iMn/seu2huk+H1d71zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqOU3IXOrwXZVoJkmsi6KdgLNhQotKOTOW31dAQ7sSkLcKrweQYBEWldQtrZ uIEZIOeeEYZGIS5amVkWrIcadFsb/3iZxEnd2/85+WJTsHV0gJ1XYxNu/xKDwLeOApP+tCKH LbjPA31QZJHh4sH7CG700+LqD+T72iruOsXfdKPW9/1OHI5gnYqYLSIly95FMzQjlPybAt/S zuiAri/Jy5v/W60BPHk0fV8pRNgdPkjuFIDMunjM8JJiTw4zzYMrhJavmnhnQYseuv4FElnJ 3nuBE7Jf1p53fQZG2u5TPwxgjJyl8Vmivf4G7dpUGmjd3yRTo8BcYEr5leaAHh8EYlvMtxyu Ziw3+ZjZxKFhnN9R6NsuTgZlVPrA6ZsHAimekcgzh0So0FcoZLoYge5k9OVL8dASTU7ps4GP JiAMy03ocATXqqK1Ti+kV/yt2lWXo+Wj2cRFIZg9eY1zhNkGo87ksD2coFjh47hbkAYqgBw9 6BHrVjlblIQMNTR7l6Hv05WseyCnbAW1brK2KdIVPuEYsDO37Ltr7PyLg5/+2xYvUzvcgPsa WEdGkdmX85ekroB8HL9oZM6Ar1W2m4XS7g0IVm/J5ytqfnSLeuGj3Ga1YziMyppvUZDKTgKt 6OEaMTJ8WmAXrlGI5P0QG7cYJVM2MmS8EQusw2QRa1iOejEPzCisXrNNLoYJb9GzctXW3yRl EZWiLoHd5N6kCwVmW9vQPYXGn1fFfjwIl5H6fb9dUC0YRlDPwfjiElzXCCou2bIzxLtaI7OG FkJqn8r6+9rW6quU7V8mRAIHNmfxhoyYSld0kPiR4BMkvyf7pGkc6YY3pu0HyOIQI6Z9/KET RYu0989cuMXsOtLBgZeoOa21+h/icuTTOxPsohc5S4lJ3YktVSNOdqZEQ3fT+7TyCcmm5R2S N+gEJufD6UKtqhs9T0sHS4bNuvN+WUuz3bbvK8n0iv8Hl0lftfCkfzYATeH/J/oTxeAAa81W cBtZP2vtK76HWSAFp6pr5mbHtxVQ2scfB75a6+Fa9pcvuCQnABcY7Nv03AtzgDPlPw8UMcn2 rgKjDRV83qLzNmywVl+5evyUhzcGqFeUJ2dzRdiq1SUUr7mlsb6575WkKUu1HhHGfqBtttRw 34XQ==
- Ironport-sdr: iTBe/WSP/RQGdh4bJvCepQyjpG4BYTcbnzUKQwwxeKZSo1m9eIVPGur5+uptX5dYVddAFL8g/6 YFQVPz48O351/CiKnV8+iVqa4Vx/dnMt3PF2f25EzuLFMXqezexKuw4q3hfBJwC6J+smhL21oD y2HK8pUhWIfi51jgd4h9+dQFyyxk2iS7JJVRqmeoWrSJXSdNGfixr9eDnqT8JjOqlSd51F4i6e nr+fzv2SECNer1Bx8smMuJFhDtlLTTX3kft8sbaWr5Bovmhwou0sugivwkLyNxGtc4OagWf3zv kpQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Apr 30, 2021 at 04:45:03PM +0200, Jan Beulich wrote:
> We shouldn't default to include any unsupported code in the shim. Mark
> the setting as off, replacing the ARGO specification. This points out
> anomalies with the scheduler configuration: Unsupported schedulers
> better don't default to Y in release builds (like is already the case
> for ARINC653). Without these adjustments, the shim would suddenly build
> with RTDS as its default scheduler.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ----
> I'm certainly open to consider alterations on the sched/Kconfig
> adjustments, but _something_ needs to be done there. In particular I'm
> puzzled to find the NULL scheduler marked unsupported. Clearly with
> the shim defaulting to it, it must be supported at least there.
Indeed, I think we should mark NULL as supported for the shim usage
(which is very specific anyway, because it manages a single domain).
> --- a/xen/arch/x86/configs/pvshim_defconfig
> +++ b/xen/arch/x86/configs/pvshim_defconfig
> @@ -15,7 +15,7 @@ CONFIG_SCHED_NULL=y
> # CONFIG_KEXEC is not set
> # CONFIG_XENOPROF is not set
> # CONFIG_XSM is not set
> -# CONFIG_ARGO is not set
> +# CONFIG_UNSUPPORTED is not set
> # CONFIG_SCHED_CREDIT is not set
> # CONFIG_SCHED_CREDIT2 is not set
> # CONFIG_SCHED_RTDS is not set
> --- a/xen/common/sched/Kconfig
> +++ b/xen/common/sched/Kconfig
> @@ -16,7 +16,7 @@ config SCHED_CREDIT2
>
> config SCHED_RTDS
> bool "RTDS scheduler support (UNSUPPORTED)" if UNSUPPORTED
> - default y
> + default DEBUG
I would also be fine with leaving the default as 'n' for unsupported
features.
> ---help---
> The RTDS scheduler is a soft and firm real-time scheduler for
> multicore, targeted for embedded, automotive, graphics and gaming
> @@ -31,7 +31,7 @@ config SCHED_ARINC653
>
> config SCHED_NULL
> bool "Null scheduler support (UNSUPPORTED)" if UNSUPPORTED
> - default y
> + default PV_SHIM || DEBUG
Do we need the pvshim_defconfig to set CONFIG_SCHED_NULL=y after this?
Thanks, Roger.
|
