Re: [PATCH v6 3/3] evtchn: type adjustments

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, May 27, 2021 at 01:28:59PM +0200, Jan Beulich wrote:
> First of all avoid "long" when "int" suffices, i.e. in particular when
> merely conveying error codes. 32-bit values are slightly cheaper to
> deal with on x86, and their processing is at least no more expensive on
> Arm. Where possible use evtchn_port_t for port numbers and unsigned int
> for other unsigned quantities in adjacent code. In evtchn_set_priority()
> eliminate a local variable altogether instead of changing its type.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just one style nit below.

> -long evtchn_bind_vcpu(unsigned int port, unsigned int vcpu_id)
> +int evtchn_bind_vcpu(evtchn_port_t port, unsigned int vcpu_id)
>  {
>      struct domain *d = current->domain;
>      struct evtchn *chn;
> -    long           rc = 0;
> +    int           rc = 0;
                     ^ I think you are missing one space here, other
                       functions in the same file don't align at the *.

Thanks, Roger.