[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/4] xen/char: Default HAS_NS16550 to y only for X86 and ARM

On 25.05.2021 09:06, Jan Beulich wrote:
> On 25.05.2021 09:02, Jan Beulich wrote:
>> On 24.05.2021 16:34, Connor Davis wrote:
>>> Defaulting to yes only for X86 and ARM reduces the requirements
>>> for a minimal build when porting new architectures.
>>> Signed-off-by: Connor Davis <connojdavis@xxxxxxxxx>
>>> Reviewed-by: Alistair Francis <alistair.francis@xxxxxxx>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> Actually, just to make sure: This ...
>> --- a/xen/drivers/char/Kconfig
>> +++ b/xen/drivers/char/Kconfig
>> @@ -1,5 +1,6 @@
>>  config HAS_NS16550
>>      bool "NS16550 UART driver" if ARM
>> +    default n if RISCV
> ... won't trigger a kconfig warning prior to the RISCV symbol getting
> introduced, will it? (I was about to commit the change when I started
> wondering.)

While, not having heard back, I've now verified this myself, I still
decided to leave committing this until the point where it can be committed
together with at least patch 3 here, so there wouldn't be a seemingly
stray reference to RISCV here.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.