[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210601 09/38] tools/guest: prepare to allocate arrays once


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Olaf Hering <olaf@xxxxxxxxx>
  • Date: Wed, 2 Jun 2021 14:03:05 +0200
  • Arc-authentication-results: i=1; strato.com; dkim=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1622635400; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=FOduCrl90ZiaFx9X3ycOUkHkthPsCWuIsPfGUyiJQyk=; b=j7RzIrqEF1T/QZctBrmETPwg0K3qERUB1Krng1RCINS7gGQyfH4jjMb4XhejZSbzsU pLMv9S2N/ZxZb4NK09VkMFKnMoVURifmP71X6FHl7gxmn8pJC4VpiuEgwV6l3C8YwNy0 1c7GW2T8i9SgpsluZvQHVYwqlP9XlNJ6dHhxewVKBdPbSS/yUKGn3z/ZFUF5DZ2p3/O1 yjWkC9oTKmBXP9yOrY/kGYKYdCe0qP3tnVWIuylOCY/vFHZnOGAxq+ZvqJ/rjlGGov1v yLLpQsM+Pxa8K3eZTWXIgQnJXjAaBtT+OXzTjlzDZiKZwsdlrLzJuTDXkbOwefvuwqAJ 2HTA==
  • Arc-seal: i=1; a=rsa-sha256; t=1622635400; cv=none; d=strato.com; s=strato-dkim-0002; b=o/k9BmSuh566IxKB34lOOia0hX76LEF/QGxZeQItKEFMoMnyk3JpSGJEKfR8ZF/qT1 e3Nndi7nraZG6tiYTYd3u2BLbgyYleLYioXD2IeNcTTRK+JCkOORGsfi8bE3HBNU7RX9 hsLR7SG4TQzqQvREe9uLRxlF1Re0Pn8Ms8wuCuPhxGxuyQDNyyXL1Bqj9H6++oCrQE80 qIvbIfycH2L5Zuu5I+WJ/eaOkJ+bEbwJ9iF27mFPjycAKm9HjhTsE3fuwgS6Uy70GQk1 6q6cftGkCl5PR/czGRjDWwP+pFjK9viMaUmtb39CYqzVcoLOoo9t7zNeiH7EJ1w0cJAr iNNQ==
  • Authentication-results: strato.com; dkim=none
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 02 Jun 2021 12:03:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Am Wed, 2 Jun 2021 09:29:08 +0200
schrieb Juergen Gross <jgross@xxxxxxxx>:

> > +    ctx->restore.m = malloc(sizeof(*ctx->restore.m));
> > +    if ( !ctx->restore.m ) {  
> 
> ... this case might trigger without the full series applied, due to
> allocating zero bytes (same for the save side below).

Such bisection point with a libc that returns NULL would be just bad luck.

See git-bisect(1) "Avoiding testing a commit" how to deal with it, in the 
unlikely case it actually triggers.


Olaf

Attachment: pgp_R9AI6OQb9.pgp
Description: Digitale Signatur von OpenPGP


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.