[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 01/14] swiotlb: Refactor swiotlb init functions



On Fri, Jun 11, 2021 at 11:26:46PM +0800, Claire Chang wrote:
> +     spin_lock_init(&mem->lock);
> +     for (i = 0; i < mem->nslabs; i++) {
> +             mem->slots[i].list = IO_TLB_SEGSIZE - io_tlb_offset(i);
> +             mem->slots[i].orig_addr = INVALID_PHYS_ADDR;
> +             mem->slots[i].alloc_size = 0;
> +     }
> +
> +     if (memory_decrypted)
> +             set_memory_decrypted((unsigned long)vaddr, bytes >> PAGE_SHIFT);
> +     memset(vaddr, 0, bytes);

We don't really need to do this call before the memset.  Which means we
can just move it to the callers that care instead of having a bool
argument.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.