[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: smmuv1 breakage

  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Tue, 15 Jun 2021 16:28:24 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HJ1jRUoVYT4kD8AIqpCF4g42R3wx0bDOHXejiemdO7c=; b=ZlfMdFeVPAgffAbVNSlJ84AkeZgSkatWENDQTimen47we0oIA/6GWGuAx6+6/Cu883GYGycHgCr42SCRnb6tGUnQxBNUBj9SfD9tKMLORtBsXgBm/nHW+H9F02uxdYSwIjN7rdas2f/92BqbUKSyyAfChGQCADmfAZVC32ZSTJadzWmdqfa4nsNfb3rKsQdOLaO+JWwCHH+PM7jdBo+T7SNEbnAFbZFmWJ+adpncOCDO+0hny644yMZ6vkaaKeA5lRmU7Xqp9teGzX4RMaLDHLbUOd8JeLy675NxFWS8Fzou4pmIUXfYgH/rk7sEjHOAcyPSlsfz+TmMEmqLh6F2rw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVMnJj3WAwP7t/RHi2okrVGJpdZIjKO0PCFXlmB+e/boURkHkK9kbdaIjIsegnxhSmz4b49ls44+3aCucbWH+hbNmPYLK7Y7qEee/wSjlqooCffkPwbO8QgVAqWyyHi9GZjaUH00Tz0pZcVrbPtRFtoeZNMEIL3SMGBEDa+2dmlQREJDnefMfJ/AuC1NE55azGzEwbPNAWps+h1PiImJgyQzfqoaXroo/dGw8ciCOj8eWLmfGkecJ1J6cC1jSgL0xojHkqmzgEfrhN7x6Yyu+lKPGL8HPgJMe5Rs3TZZicfa8BgkXdP0U6h/Cyhg7GfCnRR/DU/2bYUMWke5QYLdPA==
  • Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Cc: "edgar.iglesias@xxxxxxxxxx" <edgar.iglesias@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "fnuv@xxxxxxxxxx" <fnuv@xxxxxxxxxx>
  • Delivery-date: Tue, 15 Jun 2021 16:28:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXYY0v3XVdqEOvqESHjaQGLRWMRKsVQ9IA
  • Thread-topic: smmuv1 breakage

Hi Stefano

> On 15 Jun 2021, at 3:21 am, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> Hi Rahul,
> Unfortunately, after bisecting, I discovered a few more breakages due to
> your smmuv1 series (commits e889809b .. 3e6047ddf) on Xilinx ZynqMP. I
> attached the DTB as reference. Please note that I made sure to
> cherry-pick "xen/arm: smmuv1: Revert associating the group pointer with
> the S2CR" during bisection. So the errors are present also on staging.
> The first breakage is an error at boot time in smmu.c#find_smmu_master,
> see log1. I think it is due to the lack of ability to parse the new smmu
> bindings in the old smmu driver.
> After removing all the "smmus" and "#stream-id-cells" properties in
> device tree, I get past the previous error, everything seems to be OK at
> early boot, but I actually get SMMU errors as soon as dom0 starting
> using devices:
> (XEN) smmu: /smmu@fd800000: Unexpected global fault, this could be serious
> (XEN) smmu: /smmu@fd800000:     GFSR 0x80000002, GFSYNR0 0x00000000, GFSYNR1 
> 0x00000877, GFSYNR2 0x00000000

 This fault is "Unidentified stream fault” for StreamID “ 0x877” that means 
SMMU SMR is not configured for streamID “0x877"

> [   10.419681] macb ff0e0000.ethernet eth0: DMA bus error: HRESP not OK
> [   10.426452] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
> Do you think you'll be able to help fix them?
> You should be able to reproduce the two issues using Xilinx QEMU (but to
> be honest I haven't tested it on QEMU yet, I was testing on real
> hardware):
> - clone and compile xilinx QEMU https://github.com/Xilinx/qemu.git
>  ./configure  --target-list=aarch64-softmmu
>  make
> - clone and build git://github.com/Xilinx/qemu-devicetrees.git
> - use the attached script to run it
>    - kernel can be upstream defconfig 5.10

I tried to reproduce the issue on Xilinx QEMU as per the steps shared above 
but I am not observing any issue on Xilinx QEMU.

I also tested and confirmed on QEMU that SMMU is configured correctly 
for specifically StreamID “ 0x877” and for other streamIDs.

I check the xen.dtb shared by you and found out the there is no 
property in the master device but the "mmu-masters" property is present in the
smmu node. For legacy smmu binding we need both "stream-id-cells” and 
If you need to add the new smmu binding please add the "iommu-cells”
property in the smmu node and the “iommus” property in the master device.

Can you please share the xen boot logs with me so that I can debug further why 
the error is observed? 


> Cheers,
> Stefano<xen.dtb><log1.txt><qemu-run-zynqmp-xilinx-xen.sh>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.