[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PING Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype



Hi,

On 15/06/2021 15:31, Julien Grall wrote:
Hi Ian & Wei,

On 02/06/2021 10:25, Jan Beulich wrote:
On 01.06.2021 17:41, Anthony PERARD wrote:
Commit cf8c4d3d13b8 made some preparation to have one day
variable-length-array argument, but didn't declare the array in the
function prototype the same way as in the function definition. And now
GCC 11 complains about it.

Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length argument to map forward")
Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Ian - this (or whichever alternative might be chosen to address gcc11's
valid complaint) also will want backporting.

I was about to commit this patch and noticed that there is still a missing an ack from the tools maintainers. @Ian, @Wei, can you provide one?

From an IRC discussion, Ian was happy to follow the rule:

"Commit something without the necessary acks if you're reasonably certain that the maintainer would have approved it"

This doesn't seem to be part of MAINTAINERS, but I will use it for this patch as Ian gave his assent.

This is committed now.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.