[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] tools/tests: Drop run runes


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 16 Jun 2021 08:44:33 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6no39c4ymfMgk1XxNnp9RMGfuzkFM/lh1ZHatcdZTZ4=; b=KWIIloMhhyCuo245oqCOZ/Emu3P8tFv3+eKdz+7GYjscC1a32xQxWh8p8mG5h+kpjDEh9zhzwTHTqqSJt2777G6cO0uOyHHmO6y9q17YcT+mtRzvH/JP211yDTVfY0UrvIAUgsJFX3zrBYtqo9MAxsXXjZGdpvADFSI82Gp9jPx9EUyCVtVoGOlPjCjbqCbk4Z2LCVLXsVr7NFZvR1bUS0/ebgnn/2rIgIlQqUypmYyiH7q55HI72nWHSpSIjExMHoYteAZYCP4OhFqptwVvyIAXvjzGlASxFh4aYA/ZHeadcHxkoZwYIX3q+fxB/25ZhdueVG/DfCWaSbc7lro3lg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jt1wTM0y9cQzpBi2fBMoBVJEvVKZHKVJfM6MXUAgNZwx2tSgdviAogAeDuy/xFwKLvN/IckGJ5jWiCBuZGoHZLT+eOxk6zDEPCH1mkffU5Les8lniwiMVEUjA/IZQOaV4jUkK/GDzU8kyOeGXiXMT6GIJUr5Cgdd2A1mfuH/z6SR4fLRWvqRY6iC1ouhyJ70kYFRoa+cFmtqfaQBBWbdk1lvuao6IYGpELWmz/x1Vr2t8M6wrDZfFnhXz8ugZGb44X6NP0OBdNu1tiVaBrr8rHHTplthpmliBQzyGctudwN5bnK04/Oja53TWj98HZZ96/hwXa1m69vYe2Bo+lDQkg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 16 Jun 2021 06:44:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.06.2021 18:19, Andrew Cooper wrote:
> --- a/tools/tests/x86_emulator/Makefile
> +++ b/tools/tests/x86_emulator/Makefile
> @@ -7,10 +7,6 @@ TARGET := test_x86_emulator
>  .PHONY: all
>  all:
>  
> -.PHONY: run
> -run: $(TARGET)
> -     ./$(TARGET)
> -
>  # Add libx86 to the build
>  vpath %.c $(XEN_ROOT)/xen/lib/x86
>  

This is not only incomplete, but actively (specifically here for my
own frequent using of it, but other tests I do run occasionally as
well, and then also that same way) harming things as long as you
don't introduce an alternative way. Note the top-level Makefile
making use of these rules, and note also the run32 companion here.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.