[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libxencall: Bump SONAME following new functionality


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 25 Jun 2021 13:58:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yAhJUHImPIhAKi7vEFOmIRUhT5eo0pNQB+Ild4XOWD8=; b=UC+24ikWpMEkTjQDPlgX6o1UJuL8rjHFoio0N+MCbpOnWl95NJM0nb36DJs/6KWf6FWr3V3lZYSRxhRqKOtuUP/bd6olUEJ/+92Z8QtYBnb9BntLGr4tE+EGWhsWbPx2qz2oARKSkpvoQA7a3nb8id4JfSuZeerSaamjjp9WjSRHRQKP95OZcmppAMxjdErNO+N5Wlw/brmpkDvrWfjpzH1NbwXNHv1UsMdlo4g/X1yjTTOajdrBN+u2gXWqCk+l7qp85Sg2k9LKztqGWfR1X6xhKeE8jWrJM0gI/WcsIZQ0mVrRxYHkq8w444Rts78PpViWjpqfM0RqMy5LVPxbvA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJrVRYpjNI3z8xG3XJFo2d6XOGRWZmmMJzl7t1q0R5mZzU19MLD7L5UA4xNYdID/PHGtbrBf89MEVzQuvduGQs24MkAaPLYL4VwIdOHLLw45iVsVSj6aDKhtax15of+196vUQYU1lH80bWng4JuC4yrPi89W/7Ov3mnUE0qv58rIcW9QjVB0ofLclxNst2VDKI9qZ35utpI/rVtXdYB2ocDywesKqLyq5iuVrFPBVtY1ZpBtgFqN2VtG3Lbj0ZH2Q6PJR9tNwaq1ac12KRwYDtkvS8CyTWfiWoxyy0iegPqDEsaRMg3LGyyoWU5Bbnu6SjzixajYSBvFhDFy8FN1jA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 25 Jun 2021 11:59:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.06.2021 12:59, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] libxencall: Bump SONAME following new 
> functionality"):
>> On 25.06.2021 11:17, Andrew Cooper wrote:
>>> On 25/06/2021 07:31, Jan Beulich wrote:
>>>> On 24.06.2021 19:55, Andrew Cooper wrote:
>>>>> Fixes: bef64f2c00 ("libxencall: introduce variant of xencall2() returning 
>>>>> long")
>>>> Is this strictly necessary, i.e. is a Fixes: tag here warranted?
>>>
>>> Yes - very much so.
>>>
>>> andrewcoop@andrewcoop:/local/xen.git/xen$ readelf -Wa
>>> ../tools/libs/call/libxencall.so.1.2 | grep 1\\.3
>>>     33: 0000000000001496    59 FUNC    GLOBAL DEFAULT   13
>>> xencall2L@@VERS_1.3
>>>     39: 0000000000000000     0 OBJECT  GLOBAL DEFAULT  ABS VERS_1.3
>>>     76: 0000000000000000     0 OBJECT  GLOBAL DEFAULT  ABS VERS_1.3
>>>   020:   4 (VERS_1.2)      5 (VERS_1.3)      2 (VERS_1.0)      3
>>> (VERS_1.1)  
>>>   024:   3 (VERS_1.1)      2 (VERS_1.0)      4 (VERS_1.2)      5
>>> (VERS_1.3)  
>>>   0x0080: Rev: 1  Flags: none  Index: 5  Cnt: 2  Name: VERS_1.3
>>>
>>> Without this, you create a library called .so.1.2 with 1.3's ABI in.
>>
>> I'm aware of the change to file contents as well as the disagreement
>> of file name / SONAME vs enumerated versions. So telling me this is
>> not really an answer to my question. It may be by convention that
>> the two should match up, but I don't see any functional issue (yet)
>> if they don't. Plus of course you leave open altogether the
>> backporting aspect of my question.
> 
> The patch, including the Fixes tag,
> 
> Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> 
> Changing minor version in the filename as well as the .so is not an
> impediment to backporting.  The actual soname remains the same so
> there is no compatibility problem and the change is still suitable for
> including in eg distro stsable releases.
> 
> Not changing the filename is quite strange.  I havne't thought through
> all of the implications but I'm sure it will confuse people, and it
> seems like to confuse at least some computer programs that handle this
> kind of thing.

I guess I'm still having trouble seeing the actual issue from not
bumping the minor version of the library. This is still largely
connected to me not seeing how a clean backport here would look
like, in particular if we were to assume for a moment that the
oldest tree to backport to did not already be at version 1.2.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.