Re: [PATCH] xen/arm: smmuv1: Set privileged attr to 'default'

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 25 Jun 2021, Rahul Singh wrote:
> Backport commit e19898077cfb642fe151ba22981e795c74d9e114
> "iommu/arm-smmu: Set privileged attribute to 'default' instead of
> 'unprivileged'"
> 
> Original commit message:
>     Currently the driver sets all the device transactions privileges
>     to UNPRIVILEGED, but there are cases where the iommu masters wants
>     to isolate privileged supervisor and unprivileged user.
>     So don't override the privileged setting to unprivileged, instead
>     set it to default as incoming and let it be controlled by the
>     pagetable settings.
> 
>     Acked-by: Will Deacon <will.deacon@xxxxxxx>
>     Signed-off-by: Sricharan R <sricharan@xxxxxxxxxxxxxx>
>     Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> 
> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>


Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/drivers/passthrough/arm/smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c 
> b/xen/drivers/passthrough/arm/smmu.c
> index 1a68c2ab3b..d9a3a0cbf6 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -1566,7 +1566,7 @@ static int arm_smmu_domain_add_master(struct 
> arm_smmu_domain *smmu_domain,
>                       continue;
>  
>               s2cr[idx].type = type ;
> -             s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV;
> +             s2cr[idx].privcfg = S2CR_PRIVCFG_DEFAULT;
>               s2cr[idx].cbndx = cbndx;
>               arm_smmu_write_s2cr(smmu, idx);
>       }
> -- 
> 2.17.1
>