[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/4] tools/tests: More cleanup for automation improvements

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 28 Jun 2021 14:59:58 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4mQ6VsUPqqk/73sP0wLrxM9bN58O+3jIUWEXrgvJS2w=; b=GMXrBlwsSayYMYhVTXAmWgiF5JbA5Wkyx6EJpWfCDOdQ0bu+dCpX0dQ/PVt5wi3fllgP9BNrwUYKOCYXiWjVF0QanyIlCMG13NC1pFd/6PzwFMW33rYhETH5IiKwromYaDbvGjkQKFk+0qn/fc9Gz7/Q2JTUrKmDss5QVKJy72GoiR5Iq/3pbODwc6fUuoHz+5ds4bBZj6+ewdoPVrAsAZAG9a5PfacsdutvrSfBKmB/tIIVVR6dDs543e0ru7h5JcY8khvaqRwzLyZ7sOQBkK6o2knTGYtYcmyOqAlRkuI0ZsTgA53TYs1k9cYWCgVFyHtGEzyHMKONlchBGCw+wg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FjZkC9HvXWtttwMNKjLESiRD9kkXVN4FPArxr36cZ5rNEdyPwB3CVlrvu1aFZh1RbwXXiCYXoVoEwSxsABUIB0MDRrJGzhexxPjhnr58s45fvSnG123FsFYz08+srcZGeJXbR5GsRa7ZpHT5di019rNzRKCnFZ9coEvSDGxBygQm6kXt7NL68XbkKZkL++7w34W3Z+/d+qlokteMWC45e1BIdDnfsJj2h8eNt+EQbssSRRorxQDRVMBx8j2am6a0jJ9A3gxG9m/8kgnjUZhAJAYVqZCSv/rQzEdeGw2viGjW18A85lbtudCl2+vGMG/QWXNPLLg5/vA32Qc9inf7fw==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 28 Jun 2021 13:00:14 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.06.2021 20:21, Andrew Cooper wrote:
> v2:
>  * Fix CI failures from newly-exposed logic
>  * Drop -f's from $(RM)
>  * Drop the 'run' rune patch.  Its clearly controvertial, but ignoring the
>    problems isn't an available option in the longterm.

What is "the problem" here? The presence of the run targets in
the first place (and their wiring up from the top level
Makefile, allowing direct invocation)? If so, I'm afraid so far
I haven't seen replacement proposals by you (nor why exactly
this would be a problem).

> All other RFC questions still outstanding.

I didn't find any here or in the individual patches.

Also a remark on patches 2 ... 4 each saying "fill in the
install/uninstall rules so this test can be packaged to be
automated sensibly": Why is running (or at least picking) tests
from the build area not an option in an automated environment?
And why is installing tests unconditionally a generally good
idea? I'd view this as unnecessary bloat for the majority of




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.