[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/shadow: drop callback_mask pseudo-variables
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 30 Jun 2021 15:12:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QhK/gCUXmNcRJ3VqqlI5E6tfI53oZenKrcTVvJ4/hG8=; b=HTARWc6W1251DrHZYjbt0Juob41Ch2uEN0Ow+DxFynMdy+8n19CeBkhiJ2hQiC2AlQEcDKC+bQK1K22ikg1TiS1iWDUSCId6SfGHh6JvJHi0CM7kB6z7TEopFIQv1dex5+tsPrGf1aVQXMVxGgF+/VuSrAMpQX79bkON2zTG/K0yZJq481vfn7zXMXw1/7MbQqsP6+ApkAdZFugf6P7/q68yxnGuXZCQDwMPFaCLu/mW7mKbhkHHKJsqIySH4uZ939UxtPOqx3hI477brb7f8cdCYyzGKNiqLUOcEah+rmH9G4v3YI0NG4GYC20+Z96o9tc64U8OmcO/QfNlpRFF0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=McPdQEPhJizuoknELcl8O6vEXeWfx2B3wzOP0UjAybf4f5/rvqkXdo4jmXPdpeBUksPXkKaVykGbkkg31KjnqA9j3T+tOXgh+ZcMTDs4NuLqREMLdqTU9LtjYuWxI7QNkrbcjkBrk1JsHDVSHwewIALYFZSR3uCnboFBFwb0jDgcBmMNtRlpCqesoL6BovS1p/9c53hoDRTTnJ4EAeRNwWJprEwR5drG7LrJonNOjLxKzi8e46O/SJUEE97+L0F69Wyogo+umOS9xZzCpE8ABla+ORDHIunUwrYMVfZTgDO1fx4PVDhvxN+zKGBt9RtVLYdI2TgyVu9qXjSqXAmDeg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
- Delivery-date: Wed, 30 Jun 2021 14:22:15 +0000
- Ironport-hdrordr: A9a23:PfYBmarAGKd6nfrblFJXutkaV5uwL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBfhHO1OkPcs1NCZLXbbUQqTXf1fBO7ZogEIdBeOjdK1uZ 0QFZSWTeeAcGSS7vyKkjVQcexQuOVvmZrA7Yy1ogYPPGMaH52IrT0JbTpzencGNzWubqBJba Z0iPA3wgZINU5nFPhSURI+Lpj+TpDw5dPbiVlsPW9u1CC+yReTrJLqGRmR2RkTFxtJ3LcZ6G DA1yj0/L+qvf2XwgLVkza71eUUpPLRjv94QOCcgMkcLTvhzi6ueYRaQrWH+BQ4uvum5loGmM TF5z0gI8NwwXXMeXzdm2qs5yDQlBIVr1Pyw16RhnXu5ebjQighNsZHjYVFNjPE9ksJprhHoe Z29lPck6ASIQLLnSz76dSNfQptjFCIrX0rlvNWp2BDULEZdKRaoeUkjQZo+a87bWTHAb0cYb BT5Jm23ocPTbraVQGagoBX+q3qYpxpdS32GXTr06euok1rdHMQ9TpV+CVQpAZbyHqRI6M0rN gsCZ4Y4o2mePVmIJ6VNN1xNvdfNVa9CC4kEFjibmgPR5t3dU4klfbMkf8IDbaRCe01Jd0J6c n8bG8=
- Ironport-sdr: Tp3ZoQtkCn8r4PsH8xbegdU1EP6E2tgeVpLOTKqeYUg5WnzgJETYYgAZhn/S8qyUUavLIcq617 Oc9zwZSiJXUi1gnLJpTa3liJJmpjSkbNtwNYz3+eAn1iIbkoSHKsCswt4FaKkfxQYqpjCv9vqI b9/apX63T8117aXg/EwpfUZ75Fpd/7FgGJV9Xncfk5RVyoogJJjknXvX2Rx10dpSZBnAC2JsAw Xp5n/XTxG3jjOpRSeCwInPwtL/OdaGjkXP3KnGvVfs6O0hzWKRxektw7lQb+yhjq6TCFvoAolk k8o=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30/06/2021 07:42, Jan Beulich wrote:
> In commit 90629587e16e ("x86/shadow: replace stale literal numbers in
> hash_{vcpu,domain}_foreach()") I had to work around a clang shortcoming
> (if you like), leveraging that gcc tolerates static const variables in
> otherwise integer constant expressions. Roberto suggests that we'd
> better not rely on such behavior. Drop the involved static const-s,
> using their "expansions" in both of the prior use sites each. This then
> allows dropping the short-circuiting of the check for clang.
>
> Requested-by: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
It is not fair to categorise this as a shortcoming in clang. C mandates
an ICE in _Static_assert(). You tried to used a GCC
extension/implementation detail which Clang doesn't implement.
With a suitable change to the commit message, Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
