[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer

  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 1 Jul 2021 12:39:06 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b0xtOFMSUTTAQEmkk1wxyYJrt+czH7YUmCcT1A65bl0=; b=UqbT22COKc+pYZJOP0m6HrZZegXz8ZOJ6+VHdsQdtrNx48BItCpojTy1DP893zCyqRvE0JbHzqshAmuPqy85c9bHkO3bmLuGio9EM9Y2iwu7Era9sb1vnuJG8VyBZWYh9MNKfXzXwT+0QsCru6q70C3iizmPUibuzGEtBRxsIy6CSs1SWWnSPfP0qPK7n1O6t9D8auCsUBI068bP5fYoEiHh2cUsxXVrTSf1fn3JLTOVVMgNMnsMXsGzS19RwbOIjeOWj3gPZCqfDBqzqwwu1XxzZZpaaGuSBnn4OVFwJlHd7qNNUBDs91wOIliq8zNPRwU2RhzKyRXz17WY9mB96w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNZkTjo0MY2ruxaD+3erLgT7+G3Ew0Kor0OjbuqI5SZ7HdkCJ6X+kpqCue+99GOO/11CgVPCiErX9ZE478yJesA+n+LVmP7WRjX1L1gXulvD0dADo9yUAAxSIHXjT08Na3HrfdIBqTBOArSk2S8L3AVZAcBXCKGhw4CF6QDPqPD+MEE60+CfdxPO4SwWuV8az/I05b4GQ2XorWPqGPVMYEwd44DeaoB0i0VjRmNMFd6AFYv+DbAbKjC05udVRV1rFgixPPo4VqF639BHmaHc2vqm571ClxVOeRIAb7aEFyC2jTdI6KjqZj8GIdOsdL30z86Fuy8MTO8212cMTl4pXQ==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 01 Jul 2021 10:39:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.07.2021 11:56, Olaf Hering wrote:
> I touched it last.

For my taste, this is too little as a justification.

> @@ -381,6 +381,12 @@ R:       Juergen Gross <jgross@xxxxxxxx>
>  S:   Supported
>  F:   tools/libs/

Nit: DYM LIBXENSAVERESTORE (and hence for the new entry to be below

> +M:   Olaf Hering <olaf@xxxxxxxxx>
> +S:   Supported
> +F:   tools/include/xensaverestore.h
> +F:   tools/libs/saverestore/

I'm afraid this goes too far: This way you remove all prior
(direct) maintainers (see "The meaning of nesting" in
./MAINTAINERS). And I'm sure Andrew, who has written much of
this, ought to be considered to become the maintainer of this
code then as well.

Personally I think you may want to take a smaller step first and
insert yourself as reviewer for this library. See e.g. what we
had done a while back for "VM EVENT, MEM ACCESS and MONITOR" when
new maintainers had been proposed. I may not have a sufficiently
good picture of reviews you've done in the past for this part of
the tree, so I'm sorry if I'm missing significant work you've
done there, but surely my recent series fixing code in this area
could have been a good opportunity to actually do a full round of
review, when you have the intention expressed here.


>  M:   Ian Jackson <iwj@xxxxxxxxxxxxxx>
>  M:   Wei Liu <wl@xxxxxxx>



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.