[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v20210701 03/40] xl: fix description of migrate --debug


  • To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 1 Jul 2021 15:33:47 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+qBSKO2+RUDIgebvioIm+C3sLL6oFNRAelxqHCs84k=; b=fcdthvYqjpJT5i/BpEpGoN2l0TMBWqO+Daw4x3+q7uKBkV5xPwHeCiC6pcupYtjMyDKA3dviV/Rv8LidOiPnfyZy+4aIWMisWKeMNQ6aLemVP2xOESSCd0/KmkQbPJZpllJLrCYRg4dtMHcUggp/E7TS3RJcnSgCHqdirCcgFEcQxPiyKce/n5uk+Tx0/mys1t25J22FBiDa70RjZjYkdzTiXth6gC21jlsCrLzLdUO3NEfN7zHFIdFtDrWPJ6HrU+BPMzaWGSOKHFtOYi9KPXVLY5o51Jjf+cLnBV0xknlifwyLmLB2HwnTuBkayNLmd1L6OEzr6Na/wECdeXmOqg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ORCvRhTxcMcbFhHVBzx5dBP6q90Dbidu+UgIrbQ95wTnvG88orMYgiQ/L5mMF4CFRghmMChaxzdMHqvGMtJHIX/N9yYHCX6RucQ3dM+p2bkjhG9AX7ilvBzdaHn7LwARAr17q2NVH7H21DILhBvy26ZXNc6fITt7s8oGkkjHfWrHX9jUB4SJTk/Sn3afhNaMJ9II+dmsaXhFH6cZ049fKYf+6E1pP5NsMaGzD29JaCDnzH4lHkN/5nlZfpTkwqrnF35EALVHAPKIoRY6IuL4+yMo1o6xNcckYdftJN+hVXzK4t6sRoH8efEhHibWY1SBVfwhRI1gM6otAbMCtCmgsw==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Juergen Gross <jgross@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Thu, 01 Jul 2021 14:34:00 +0000
  • Ironport-hdrordr: A9a23:RqCfVa/rb8CwgErhkKJuk+E6db1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYVYqOU3Jmbi7Sc29qADnhOFICO4qTMuftWjdyRaVxeRZg7cKrAeQYxEWmtQts5 uINpIOcuEYbmIK/voSgjPIaurIqePvmMvD5Za8vgJQpENRGsZdBm9Ce3am+yZNNWt77PQCZf +hD4Z81kGdkSN9VLXLOpBJZZmNm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTjj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZvA+1Dr1fqOk2lqxrk3AftlBw07WX59FOeiXz/5eTkWTMTEaN69MBkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l3CzvWEpnYco/j9iuLMlGftsRLEkjQRo+M9qJlO91GlnKp gvMCjk3ocSTbvABEqp51WGqbeXLwYO9hTveDlJhiXa6UkPoJjVp3FojfD3pU1wg67VfaM0rN gsAp4Y4I2mcfVmG56VJN1xDPdfWVa9DS4lDgqpUBza/fY8SgzwQtjMke4I2N0=
  • Ironport-sdr: a82aOPRQx/nSrCKDlwoAPX+syTSqIQMruZz6N7vZvfjX53EuxnwUx5Y5U00pKK1V5aESPaCPqy LbfG/z/C1aJwhCNpDZprRt1VZZ0A/9s3neohdXPFIi41wi2irekK3ejEYd/uHei3m7/+0P7K86 lQxY7JbO+BP6PqKjxwNWzxqlKNRGdG40JdW+zWDXoNx3OPdJ2C8hI24+iVQPWDH7G/gEtaRp9I ye78RetwUPCClRYJEw1ZSPlcaUR5FqwKp7kSY5jRMyOb+FqM4cDckMKDXTIsPuWAPIb7x92Hta stc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01/07/2021 10:55, Olaf Hering wrote:
> xl migrate --debug used to track every pfn in every batch of pages.
> But these times are gone. The code in xc_domain_save is the consumer
> of this knob, but it considers it only for the remus and colo case.
>
> Adjust the help text to tell what --debug does today: Nothing.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
>
> v02:
> - the option has no effect anymore

Since when?  It was absolutely critical to debugging issues during the
development of migration v2.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.