[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v20210701 33/40] tools: change struct precopy_stats to precopy_stats_t
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 1 Jul 2021 17:45:12 +0100
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "Wei Liu" <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 01 Jul 2021 16:45:31 +0000
- Ironport-hdrordr: A9a23:c5dWiakvNne2PxP/O1u4kVnY4nDpDfMqiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdO9qXO1z+8X3WBjB8beYOCGghrrEGgG1+ffKlLbakvDH4JmtJ uINpIOc+EYbmIKyPoSgjPIaurIqePvmM/HuQ6d9QYUcehEUdAG0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLomSs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlbAkEyzzYPbiJaYfy5wzdk9vfsmrCV+ O8/ivICv4Ds085uFvF/ScFlTOQjwrGoEWStWNwyUGT3vARAghKT/apzLgpDCfx+g4uuspx37 lM2H/cv51LDQnYlCC4/NTQUQp2/3DE4EYKgKoWgRVkIMIjQa4UqYJa9F5JGJ0AGC789ekcYa JTJdCZ4PgTa1+ccnvI+mJm2tPEZAV6Iv6qeDlMhiWu6UkZoJm59Tpv+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBUukChPQHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33J DMSklRu2I+c1/nTceOwJpI+BbQR3jVZ0Ws9il0j6IJy4EUhICbfRGrWRQriY+tsv8fCsrUV7 KoOZpMD/LmJWvqEoBZmxb5R4RTLncXXsETp5IjQFSFrtjQJoCCjJ2uTB/3HsubLd8JYBKMPp IzZkm/GCwb1DHZZpbRummlZ5rCQD2OwbtgVLPX5u4J1cwHPpdC9g4IlF+++saHQAcy+JALQA ==
- Ironport-sdr: x4UbEOTOCt/EN0W4ahuZCEizoyTjrBKdA67OJj+ehW6gThDWBnpdpnhgEZlyEAXZs/emnv/DO3 DRLVm7WxKM/FIJVxmH12g+onW/f6oty6E+fEpPBaTe2om5Xr1b13vbykLIMydZtGSXmCGeFUnS Mba8I6R63TF0qEdQj9A0D1cxV7h8PsxLeGYceIy3uf8K8dtwyqbiDqStVBscctlYQ2T5K0ZZos MJdh4BwKQ8/rAXFj3cSs4n8NOqLnu5fZGbDv8yVo9JRiIaBwiiDOM6vjuMkhMIcr2mwr7wgYH/ TIo=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 01, 2021 at 11:56:28AM +0200, Olaf Hering wrote:
> This will help libxl_save_msgs_gen.pl to copy the struct as a region of
> memory.
>
> No change in behavior intented.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
> tools/include/xensaverestore.h | 7 +++----
> tools/libs/saverestore/common.h | 2 +-
> tools/libs/saverestore/save.c | 6 +++---
> 3 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/tools/include/xensaverestore.h b/tools/include/xensaverestore.h
> index 0410f0469e..dca0134605 100644
> --- a/tools/include/xensaverestore.h
> +++ b/tools/include/xensaverestore.h
> @@ -23,18 +23,17 @@
> #define XCFLAGS_DEBUG (1 << 1)
>
> /* For save's precopy_policy(). */
> -struct precopy_stats
I don't think changing the existing API is a good idea. It's probably ok
to add a typedef. But can't libxl_save_msgs_gen.pl been able to deal with
thing like 'struct precopy_stats' ? It seems to be able to deal with
'unsigned long'.
> -{
> +typedef struct {
> unsigned int iteration;
> unsigned long total_written;
> long dirty_count; /* -1 if unknown */
> -};
> +} precopy_stats_t;
>
Thanks,
--
Anthony PERARD
|
