[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/Makefile: drop -Werror
- To: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 2 Jul 2021 18:34:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bROnHpnTR/M8aKMS4PXc+XiJb4a9Hhm+XOczIWCLeyE=; b=R6Xnme82RYiYm4K3ty+nPoBRtYZDxGopbK4zv5Hf4iUA+oCaoQWiCVlhzxA+sjOJbMZv23D+xADdKB85qBwdojbEVDxjqdulYqdG9WnmeVaqqsFMKSY0gl7TkCyuU+uoLMLI3rGMna5IieGhPlzbdKbF05c+Fn5kT9CU/N7qwFkTtvljxc+KsofDO8gik1C9tsKzY5bzoe5YnFpa4x2TmnwaSDSiRBVjnZp5nKKlUM6k37O7C8iVT2NBvGmIEfMqS9OMtl2AydSznjCTE2cplvwpPnK8Ls7k5W2889lX7wrwY1Bk5J7YGUgPGWurwFd6OK1cnSv1OzkNAbFQkUC42A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBTr9ko5XPMPiY67MCrTYkdglpF4NPKVMZvW6TulUwZ9RvVW96W3Ws2jjoALr6VXqk+46Y9F8MMObqUCZTQnQJ8wthvXYgk49Mx2YIPFVtwBn8hBAOsL5UrO0iVdZeZVuK6Z+zSbzzZgP5NJJwPIrmFRS1oK7gKjIuiLGO2zNFaiZJXEaod2FlpyK5+8j66A4Uq9RJoRDT1wzdMM2ZBSkCsikhvSq3dLrERxTK004RVUg0x04+7wexAGvircOrv3NrrSY5Lx5YQo58xSciNpLO2fy7NDELE9vhL8ybQcjcmR3nzS2nvnaSphiskxeEbzyvlPzZBMmIls4ErK6fgsBA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Delivery-date: Fri, 02 Jul 2021 17:34:34 +0000
- Ironport-hdrordr: A9a23:kF/XpKgFMhyVawMVP3gCZrJ7s3BQXzl13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVoMkmsjqKdgLNhdotKOTOLhILGFvAH0WKP+Vzd8mjFh5dgPM RbAuJD4b/LfD9HZK/BiWHWferIguP3lpxA7t2urEuFODsaDp2ImD0JaDpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlIawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbonttrcZrau5V+7f63+4gowwbX+0WVjUNaKv+/VQUO0aCSAZAR4Z zxSlkbToBOAjjqDxuISFPWqnTdOXAVmjLfIBaj8AfeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfGX9dQnGlqz1vitR5z2JSLsZ4J0upm0aVZFbZK5arIQZ8k8QGJAcHDji4IRiFO V1FsnT6PtfbFvfNhnizyFS6c3pWm52EgaNQ0AEtMDQ2z9KnGphx09dwMAEhH8P+J80VpEB7e XZNaZjkq1IU6YtHOtA7Sc6ML6K40n2MGLx2U6pUCra/ZA8SgDwQsTMkcoIDcmRCe018Kc=
- Ironport-sdr: lvLqR0Xt8Hcv7hJcDkOC6Idfk8jMj1X4SDYxuoBcRpETUo4IVNCAXBIPn+s3WW0sBW6hDtBT+i yzIKQiYHvUFJRwoYq0QobDvuZbEj5sRdGalSVxhPTFibO20vqrgwr2KHiy6RpNH6pU4PDmqwYM 6X96ZrK23J9MXHCr237pN9wmoKM40zj8jso7ryukTC+WeHIpOb44oNOPziP4GUUwpOtx5DeH1V AnDAHOBDr+ZaFiYp9pwykDTgvVh9v36k5+TvFN7p+woxAxEycwwKmJxVVJ3NzoaF5NW6t5u2UP Y9Y=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02/07/2021 18:06, Fabrice Fontaine wrote:
> Drop -Werror to avoid the following build failure with -DNDEBUG:
>
> In file included from <command-line>:0:0:
> /usr/lfs/hdd_v1/rc-buildroot-test/scripts/instance-0/output-1/build/xen-4.14.2/xen/include/xen/config.h:94:0:
> error: "NDEBUG" redefined [-Werror]
> #define NDEBUG
>
> <command-line>:0:0: note: this is the location of the previous definition
>
> Fixes:
> -
> http://autobuild.buildroot.org/results/66573ad0abc4244c0dfeac8b684a7bfcc31c0d4d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@xxxxxxxxx>
For better or worse, It is Xen's policy that -Werror will remain. 95%
of the time, it is the right thing. We will however build failures
whenever they crop up.
This one is weird though. How is NDEBUG getting in twice? What does
the rest of this build environment look like?
~Andrew
|
