[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Mon, 5 Jul 2021 03:16:46 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jnVNcCm/QzGCSGwzbXT6ZdtSblAWVZ7Mm2ZbLdBHPQA=; b=ZayfpNC8QPWg/VyMRdsxPVLrefIt/bzWMjyAF8VHycyAR26OFsAQCO68cJwtOrsstRFpoUB/yEIhRfgUUzs2z9OnhM8FBB15OJXJ+Nl2V2hQuXMX24iq3KheEeOhYJpZaDlWGT/Se+DPH6vHRGWB/ByrLSqGoYmClnsnWG2jOL60jhK8y9AtK87YE3j0NwFK7vAmAhj+gXZ0X82mgJ4S4VPKK4rrR70tzUjXfgGpumm65MeCiY18Rpi1cAHysW1zS5wJKQ3hMkoI2NyHisWOHYbRWSdKzGsgzy+G1TLT1P93kD++Jgtxy/QpVaQCcJsZz9ikLUtpkfKp80+J32uUsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqoC8OqlGTDVXRCFytDoLvJ1iyUZzOy683TXJIEHSJkuoLnagbyz43uXIEQFhz1Nocq9xhN5LqNtVMpHssQjKT3toct8yXH/Jh2xuvJ1vtCLpVCNT5r6ASybE9epwBgY1XVG9udn2OG92e69QVTfXiHsej3YWMLSRArrwP+wvv4XdLG66F3Esi9X/07bGhsuZEJH1Z+KzPhtpDO5tJH3G71/lnfBstTikxNDFfus5hOneq9+6wl7vbUCOpaMjtqxCs5DN4vKLu/tXFcDV5jtvqIVkjbbB08kNRagw235vgMc+Q5FJvoy0NG8Mn4aBYiF63TzRj9ghlCeToLGFtcs5A==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Mon, 05 Jul 2021 03:17:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXW0b0CeS4ToPVJE2MjFHfl516uass+MuAgAbnTUA=
- Thread-topic: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION
Hi Julien
> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Thursday, July 1, 2021 1:45 AM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>
> Subject: Re: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION
>
> Hi Penny,
>
> On 07/06/2021 03:43, Penny Zheng wrote:
> > For now, since the feature of Domain on Static Allocation is only
> > supported on ARM Architecture, this commit introduces new
> > CONFIG_STATIC_ALLOCATION to avoid bringing dead codes in other archs.
>
> Similarly to patch #2, I think it would be better to introduce this Kconfig
> when
> it is used or after the common code is introduced. This would prevent dead
> Kconfig.
>
sure, I'll remove this commit, and combine it with the codes where this config
is firstly used.
Cheers
> Cheers,
>
> > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> > ---
> > changes v2:
> > - new commit
> > ---
> > xen/arch/arm/Kconfig | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index
> > ecfa6822e4..f165db8ecd 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807
> >
> > If unsure, say Y.
> >
> > +config STATIC_ALLOCATION
> > + def_bool y
> > +
> > endmenu
> >
> > config ARM64_HARDEN_BRANCH_PREDICTOR
> >
>
> --
> Julien Grall
--
Penny Zheng
|