[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxenguest: Fix migration's debug option

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 5 Jul 2021 09:57:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kDakExeGU87B0Ei+ei/sjyL0MKjhCwbbAD1XFe3zn7o=; b=W0hkntrt2Czsj8Z/hodmvxJK3ZeOLw5Ay57lcqmykKOrZZgoZxpZmlRCzLfr0O8RwStKVDfK8IG5uxHzHB9or65zIlZtjX4214iqrlh09IVfO4T250gOW46ZL7YumyeRCHgzlPhV0TSuE/pI1z4UgAmxwxKikayGRqB2nGMRpLWwPYt2VcLIDWZlcP6wgMi6VpqvZ7ff6LNe9hT/JTu+1BnBB01/aWiWbC/WgnaRuj5R4YSY1YW+X0RKPtNTw/Jl+bfWDNXYLfiFtu3zjuKMGzIzua3f3hN9DQWFBT35JmrUuSDQRRYLosdWspseTS/cLMQGFHsvCE4qiJjPmkRvkA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2mfF9NRTqm8qMt/aDU8xdS0rYprOLo+idq0pjAZUTvKlkP2ONNranpuEcrObJdco1yFdE/K9xcwE1Z6GclHytF8ttendTQ8+Y7HHaj7oVs6cqtobGKoHCbws2n9yyYXl2akEJtIdy2FmTow2IfWSlMCdkovgdhvRq7RyAzzfYQO199wjOWUEoQC1f9pZOy5uCuydH1//s9FW4XTtPJOnT3RRzkylX41YU+kSxmX4iwiNsQICfU5VkEiXUAzj8j4tf6PuyntojCU0pTppW6GM9u8Zw30svjPNN7z242imgP89LaPfIFK7+Fpdvu92s4ZRuXnWh5t+8gjYH3oP6d49A==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 05 Jul 2021 07:57:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02.07.2021 21:03, Andrew Cooper wrote:
> The code has gone through many refactors, but the first refactor was the one
> which broke it by inverting the check with respect to checkpointed streams.
> Fixes: 7449fb36c6c8 ("migration/save: pass checkpointed_stream from libxl to 
> libxc")
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Olaf Hering <olaf@xxxxxxxxx>
> `xl migrate --debug` might not be perfect, but this at least brings it back to
> mostly working.
> I don't think dropping it is a sensible move.  In particular, it is invaluable
> for testing the logdirty infrastructure when migrating a memtest VM.
> If anyone has a clever idea to fix the grant problem, then we can.  It is
> after all a debug option, without any specific prescribed behaviour.

What is "the grant problem" referring to here? Neither anything above
nor the offending original commit has any reference to grants, or a
problem with them.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.