[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v20210701 12/40] tools: unify type checking for data pfns in migration stream
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 10:53:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9C459icUbgkKjFDP9Oja5oWJTL1qOW2C24GH7Zbt7c=; b=C1RoFX2O3s2ta1jjmYG9Ov5GKQcl3brpmRIBGxEIoLe1ja+YU5Vynz37rGDi/2fSitvEyQFnEEoV7PpP5lrlJIU3SvfatU12nxBALadeb6LkXNo20TZyXGSPWAWaOC9lnhIZcSU/afhFzQKIh9nRi70ofR/663wY/yfgrNzRQ/7ArLqjoFM1QPza5vKnSWKjGhYyWzeJV3B0M2JvWH1qTvimNCI/By6Ctw96tEXPZa0bJc8Ybtil7S5astUKN63YALjia7Q6Fr94aUaH9S3CxR1xyY8kxY6LFiqKfQtOOZMsXOuEmq+qq0wC/H4jurJlVgEGgFtpY429KXrFRDsYUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBG7RNrtl206LrkSGlx7H8ihLbbXqqBxsLnQAkKW99B8RytaxPrXC1fleaKQDWVYcEdCt4RqtZLEyZq12EXfdBYyMtf2t6phJMc4Y4SkBUS5AK9IjDu0gcuez/Dd/xCIyaFP/++TOmEm6kXbcTiaYic0QYk3y/yBc0n/nBTk3yUdrZNzSXtjWlmOR8RwMxv5/4TYE73+bFcTw0EUsTizfnpQcPwkbjEyUl9GlbjvQyjRYBoniLDdmIMeBw5fntJkurnV0Uzc4LaXnNtgxuR2E1j0awGLOv5et5zgasTEa47qKgUnwo0OLTV01kmfPyRYHm2NzSdIYxdTMRt6DslqXA==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 05 Jul 2021 09:54:15 +0000
- Ironport-hdrordr: A9a23:suIryKDkeaPV13PlHehHsceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LS90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkNK1kJ 0QCZSWa+eAfmSS7/yKmTVQeuxIqLLskNHK9JLjJjVWPGZXgslbnndE422gYy9LrWd9dP8E/d anl7F6T23KQwVnUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iCnz4Qe+BIr1/BdGC8phXgnyP61iw11nPkwViExVP+vM3QXlsBeol8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVittilG/rRMZ4K4uZkRkIM4jgYJq3MgiFBs/KuZGIMu60vFnLA BWNrCf2B4MGmnqKUww1wJUsa6RtndaJGbMfqFNgL3N79FspgEP86Iv/r1Wop4xzuNId3B63Z WzDk1JrsAFciZEV9MxOA8+KfHHQ1AlFii8Tl56Z26XTJ06Bw==
- Ironport-sdr: Me6upqrVxExRVWC/yWJPKlk+nOeVk/G8vvhNnTrL9ou/2duBElbyHHnbLOIVqRaII2SpT+/nJU heSb1nTpOkQxcJd7ePda4odd2CB9r8arnt2KbWnaLe7t8dpBYhPlsgOI8oplca9raquosOUXaj TMlXUk/KqntWDXSYKFsoHgmCqYhc0gE33vycUMQGKZ+Y/750FY1bBRCAieqjnFr4IW+Pe0LA91 ND/oZQ8i1LE7N/0QHb/M7xGcARFcav/y8uJg9XBng4w7pgxrmp1Y/7dBdWu8twymqwnmaM5ucm rEI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/07/2021 09:59, Olaf Hering wrote:
> Am Fri, 2 Jul 2021 20:43:13 +0100
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>
>> Anyone adding a new page type is going to have to audit/edit each of
>> these helpers. I think it would be better to write all the true cases
>> explicitly.
> You mean the check if a page has data or needs to be populated should look
> like sr_is_known_page_type, where each known variant is listed?
Yes. I think that is a safer approach overall.
~Andrew
|
