[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/libxenguest: Fix max_extd_leaf calculation for legacy restore
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 11:26:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xtycx29JKBGCYECyiI+oR4jzzwt4Bm61OsfO7gVru4Q=; b=NF3R8i5/vUyeTa4dD+vWdvebDdOl+2KvjNmzAD8+Hwt0KS8oQfsLydtaOj1JsP+xYOXZWiufhX6RTOuOFIZIbFg+7Gcyo4SXPWCH+uBnZgGIyG2kfPUK0+hLmbwQ4Q7jnxJFraF9f9hurRVwNGaOPdkD7Q22EazAuSRoMbpmzqujCALdivswPgrqMgacmXlgAD2mJboXY1xrWlQdrBYXSJ0xYKd1ekYYAsYhKUah/Ul4OsGY4RUMXkdssNK+p7um+cPaHeMMgaQ7FcgqoUrKWt4C6acad9f/Rrv3cFxTlX+jUXPySc0t2OB1BgqKet3K0lymiccPTW0mB9eRDPMp1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4OFsTj4H4arsur/22GsgmrYPudbtVeRiySAzeLDMqVZebCE+3IV3jY/xim7hRM6oFH3GLrl+TmSU5bAgKvnEgqaUHROX7gs4+EAwS1cUQBN3NdQzS/2o8GQ+qqxYCdORcUDmNCoqwjwipn+VwOmq81n3kyiCbzNhzSNJ0hX1aHZEqPyct0CQFpF9M/vAbYo/pZPLkaI7kcDCt9MCNkumPYxV7aNHed8GYX+NGZFL29JJ29d71iimX5KDidzLYNu6hlbGmhs7dBdfIzYZEZGNtc1Q7CO+Hv66nM91PfAk8U8UzJsVfFQg2Ea8023/C0zz+VCrD/4/c5M5zFzhbJx+A==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Mon, 05 Jul 2021 10:26:48 +0000
- Ironport-hdrordr: A9a23:XEMBj6DyUKXXJvblHemi55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9yYhEdcKG7WZVoKEm0nfQZ3WB7B8bAYOCJghrMEKhSqafk3j38C2nf24dmpM NdmnFFeb/NMWQ=
- Ironport-sdr: 939O6f42u88o3HqymiMS/n5catIRZo8ync97JO9hFpz62CRa2nxOucz9WKo2AOFCdmRlfDPX7G skOiSmatjcTeblHSnSJWMVI9uaqFupIGYrIkWFJPNGr82513D2ctwjRNT65HcODaA8Zl8bHrbU M8pCkNWC9Nng/AFjJjvT+IMn/sbX2dSEZ354D5/HG405mMenzbXoYQbDcRgUy1kKaoiTqwSckw 4qwbUg+vxhAGzxqsVbv5rZtfsewy2z2yG0/lR7xyX0/qcapsZNIXLSZ8lWMEkCaoUShqbfZSoI DLk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/07/2021 08:35, Olaf Hering wrote:
> Am Fri, 2 Jul 2021 20:03:34 +0100
> schrieb Andrew Cooper <andrew.cooper3@xxxxxxxxxx>:
>
>> Fixes: 34990446ca91 ("libxl: don't ignore the return value from
>> xc_cpuid_apply_policy")
> I think it fixes 111c8c33a8a18588f3da3c5dbb7f5c63ddb98ce5 ("x86/cpuid: do not
> expand max leaves on restore"), 34990446ca91 just revealed the bug?
Urgh... That's what I intended to write here. I'll fix up.
> Either way, this new variant is what I had tested last week. But with a
> trailing "u" for the constant. This detail may not make a difference in
> practice.
The trailing u doesn't matter in this case. Furthermore, the way min()
is written, the compiler will object if it were to be wrong.
~Andrew
|
