[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 10/13] libxc: simplify HYPERCALL_BUFFER()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 5 Jul 2021 16:47:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/dmB+97IHpmQpJevm3xwUDf/YzGHL/Nm7Ividwuzmts=; b=Dekkn/7N558gEjQlmPogXLHo0o8+KR25QsV8YjfH0gzR6ry2qFGwXGHey7OzWxfwHqHLRYVa4GVNmNHNhP047goWLGp2xsbDvF8GYVbdaJ98fSm/Je1DrrITSpftFcaLApKPP7UW4RZnqvF974GWwp+vlCqkqIFlIUwJmQSKhhKOlCyNQSEc86Poe/2R6uUY4BxdvHD8SWA1H76kfdoV7Zlk72/KMAejecfhTVusJ3On+E1xaqibVSTTYSBDb0dSmu6Qi93v9uMdGnWm3LEqs9RpjjlrMhLwtZEIgcAymnDq1jH+46XJWi1ldFDiwloHKrjJiekdYfUNqOyerCNohA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JsXn1zkS16V3rWhffDK8FS59tMcyZAH+zAFnYfFiS49Uy/rht5WoSWE9jdqXo+dULd9jgoVIjT5yVeeKRZxnXkCT2GqjdIRHPKXqO+0o1tfWfddouv2O3VUgPoYf5WhyScn6rORDcwZf9w6+/muYtihrz4GYuuBFXNl9I2qoruyax/fOevVjt0JIuZw1eydp6J1JBG2wxqHrpLRF1tVt6vMODZWm6MA7Yj/dpH+j6HOD3HDoxncz65RVdzBx7XG7rCUB6bw0aKECR0vWohdvjEcm3uhtlAiCJq5Vj0I+efw+czVZXbqZsQsXI0v/MITtRfsFFp/5GreD5bUPbK1Llw==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Mon, 05 Jul 2021 15:47:51 +0000
  • Ironport-hdrordr: A9a23:o6R9aK9iYQYtcKSmDJpuk+AcI+orL9Y04lQ7vn2ZKSY5TiX4rb HKoB1/73XJYVkqN03I9ervBEDiewK/yXcW2+ks1N6ZNWGLhILBFupfBODZsl7d8kPFl9K01c 1bAtJD4N+bNykGsS4tijPIb+rJw7O8gd+Vbf+19QYIcenzAZsQlzuQDGygYypLbTgDP7UVPr yG6PFKojKxEE5nFfhSVhE+Lo7+T8SgruOeXSI7
  • Ironport-sdr: afdDIlDQUrZbdpWWt9ZkSZRAeBgbbkmU+WDBezKWQ8aQsBr8K0foFql9DghUHT1uPQAk1yDk5s bSAFJNa/b03/ZGGlk9On+9cI3OJYrcCOeByOQ+U7JgAiW3hmOt3wx0qT3S6vubOLk5Nxz4X9mL 77/kmMyfGwi3r5iky8f8UCsLctqcQwPPCCw/2zmxiv8/e0ujVJht2w8scwumFqFYMfyXblzNDE xqd/wS2bwDZ8XnOdgfU2/K4oeEeXM2FCC2Y2ID4j6nak0yYdKUpOJyNVd3rQ/vZxa+27coyquy Ej4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05/07/2021 16:16, Jan Beulich wrote:
> _hcbuf_buf1 has been there only for a pointer comparison to validate
> type compatibility. The same can be achieved by not using typeof() on
> the definition of what so far was _hcbuf_buf2, as the initializer has
> to also be type-compatible. Drop _hcbuf_buf1 and the comaprison;
> rename _hcbuf_buf2.
>
> Since we're already using compiler extensions here, don't be shy and
> also omit the middle operand of the involved ?: operator.
>
> Bring line continuation character placement in line with that of
> related macros.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.