[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow

  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 6 Jul 2021 08:39:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jvWQDikLgE2iDToynKipJWDFqS3lsRtRHFnNr1/61FA=; b=PK94WwQj8fPTXNcbBhfzCb0/LH6AxS92NMwEd4fZz7v9tKUcPaf27k3k8usD+Vd2mfNA0iGhxoUxe30QlrzEpvqzI9POtRY0g4894ybK6B1raeOOOAB05Y3kMpjiflfwWAxnSKf67ZGGeUlOuzteI2zNc4jtZ04nhU+GMl1vaHCmm0mosPrj8PQ21WUYaagnk3Sx0SvL9DXaS5b9hYS8OumFWO8ASvNQUB0z3YiIr7/heGV5rUyDH4MtrAwcRqlkYoRwZiGPx3xbtnj2QmB4YoDyyLdzCNzMmxZGG7VAuV1uGK+HNh6XRdL0/v1tttpLhDZIv302sBrYd3EIGAs4LA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YgUnw/9kfJbENPqh4Jl2uEDEJJ46FxZozJdcISDOCcNiqfQPgOHJiX+z011COrevKltjAtB/3Sj5LtVp9skuEGSv7w0WjYFLbLVASidKdNJ3AP9csP8nNgpCEQ9xo9ip+h42koUmql9JHEYHSztbB4HJa15yFGVmfJhhywt5HlRN7DME0SR67R6c6nVi+IUfvjKGOCjwetF4V0v5A7sVbtC2LkdnGpfuxAqOjlVdL7NavEd3ZHx5wRC4NX2UU1QDckbTbgM/K2W+kIhOMZKXdvCAkrTwWryxGMgFm2Y6VmH1bbEs+HrVbiEL+4Hy6ws+6bYfUdmZWUvHlzbcX0xXEw==
  • Authentication-results: xenproject.org; dkim=none (message not signed) header.d=none;xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 06:39:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.07.2021 19:26, Olaf Hering wrote:
> Am Mon, 5 Jul 2021 17:13:28 +0200
> schrieb Jan Beulich <jbeulich@xxxxxxxx>:
>>      ctx->save.stats = (struct precopy_stats){
>> -        .dirty_count = ctx->save.p2m_size,
>> +        .dirty_count = -1,
>>      };
> As said earlier, a consumer of these data may now be unable to initialize 
> itself properly. Without the patch it would be able to size its private data 
> structures properly to p2m_size. With the patch it can not know in advance 
> what the upper limit might be.

And as said before, besides the intention of this being usable for
sizing purposes not being spelled out anywhere (instead it is
explicitly documented that -1 means "unknown", and the value really
_is_ unknown at this point; p2m_size is only a wrongly assumed
upper bound), this is useless information as the size may change in
the course of migration. It is a present limitation that this isn't
handled properly, which I think would better not be baked into
further places.

> There is no in-tree consumer that is affected, and I do not have an 
> out-of-tree consumer that might be broken by this change.
> Just saying..

Sure, but (as is the case for Andrew's replies) if you want me to
change the patch, you need to not just "say" something, but provide
convincing arguments. So far I've provided counter arguments which
weren't proven wrong or at least inapplicable.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.