Re: [PATCH] tools/xenstored: Stash the correct request in lu_status->in

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 05/07/2021 13:49, Juergen Gross wrote:
> On 01.07.21 16:03, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > When Live-Updating with some load, Xenstored may hit the assert
> > req->in == lu_status->in in do_lu_start().
> >
> > This is happening because the request is stashed when Live-Update
> > begins. This happens in a different request (see call lu_begin()
> > when select the new binary) from the one performing Live-Update.
> >
> > To avoid the problem, stash the request in lu_start().
> >
> > Fixes: 65f19ed62aa1 ("tools/xenstore: Don't assume conn->in points to 
> > the LU request")
> > Reported-by: Michael Kurth <mku@xxxxxxxxxx>
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
Committed. Thanks!

Cheers,

--
Julien Grall