[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 4/9] xen/arm: static memory initialization


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Tue, 6 Jul 2021 09:20:23 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JRisGj/Pzaucyme7fnfy2Tqri2vdi7ghvIx0NcGK94=; b=nhglPWR0dB33gDq3RF30oRxFP59gW5I4hZcSDpSM4O29pwGItcpRb3ASzX4iJkIb7RFLN+hUxNA9PfQ7kVe7NTAn+RpBoi9SmUUtphW9CjTEMq3bZ2IPSWFTs8xq+C3uin/plf14ayRTSJ4Jiqkh68MvZCz6+wAY9UszXSWebUX/K3/t+t/6xQYMGwM8wXlvYO4fdEyHcxNVUTQSaMNrr4cdQZ6Qps8T8kUAX4Q2Dv2xj+lNuQTDJ592ZKzibSTU7Y9wo6Yi97MJJU6//ZFl6zplAQuF6tMBfIFH86xVrkRUV6kntjJG72D/sb/+6Q8FehCCh6v6BwtV00JOdEokgA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cL2LZ9Fhbjck1rIgN18vvSV8d0wPOLNFNzOcgOa2g9Ogeodg5RYYJHov0DISdNBNsBQApTyKq4/wUgl/GaKt6uKd6tw1mRtZbV9Ynwb7cM9DVVCT26EDOPaYotL9v0q/BhP84MKtdgo1dOECoZrgU8Dk7UwMiw8/ScthoBftWYEaJVl94jnDV6i4Hgtk8saRh1KJbGMU2ibD1sPXi0sv21SdMDGQ8inPYoajf2eJA/COg7bcTDTPhFgNjhLAgeh6DKk5hbe/tCm2nQ+CT6vYPQ1KVqraFDI04FFP74sBZKnZ3+xkPcSKUDG5EUpX3a0rl2M9bJ0RHjHpcaF8u1wLdw==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 09:20:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXW0b3OiAcoe7xDE2AVcNY0dwUCqss/50AgAck2tCAAbJdAIAAALLg
  • Thread-topic: [PATCH 4/9] xen/arm: static memory initialization

Hi Julien

> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Tuesday, July 6, 2021 5:10 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>
> Subject: Re: [PATCH 4/9] xen/arm: static memory initialization
> 
> 
> 
> On 05/07/2021 08:28, Penny Zheng wrote:
> > Hi Julien
> 
> Hi Penny,
> 
> >> -----Original Message-----
> >> From: Julien Grall <julien@xxxxxxx>
> >> Sent: Thursday, July 1, 2021 2:10 AM
> >> To: Penny Zheng <Penny.Zheng@xxxxxxx>;
> >> xen-devel@xxxxxxxxxxxxxxxxxxxx; sstabellini@xxxxxxxxxx;
> >> jbeulich@xxxxxxxx
> >> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> >> <Wei.Chen@xxxxxxx>
> >> Subject: Re: [PATCH 4/9] xen/arm: static memory initialization
> >>
> >> Hi Penny,
> >>
> >> On 07/06/2021 03:43, Penny Zheng wrote:
> >>> This patch introduces static memory initialization, during system
> >>> RAM boot
> >> up.
> >>
> >> The word "RAM" looks spurious.
> >>
> >
> > Thx. I check the "spurious" in dictionary, it means fake? So I will leave
> "during system boot up"
> > here.
> 
> Yes, this reads better.
> 
> >>> 2. scrub the page in need synchronously.
> >>
> >> Can you explain why this is necessary?
> >>
> >
> > Since I'm borrowing the logic in free_heap_pages, I'm also trying to cover 
> > all
> the scenarios here like it does.
> > So I assume that free_staticmem_page will not only be used on 
> > initialization,
> but also when destroying/rebooting the domain.
> > On these cases, it is necessary to scrub the page, ig.
> 
> I wasn't asking about scrubbing specifically but instead why it is 
> synchronous.
> Sorry for the confusion.
> 

I've read asynchronous scrubbing in buddy allocator, pages that need a scrub 
are added to tail, 
and specific working thread is working on it, hmm, imo, I don't think it could 
be simply applied into static
memory. :/

So I put asynchronous scrubbing in #TODO.

> Cheers,
> 
> --
> Julien Grall

Cheers

--
Penny Zheng

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.