[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Jul 2021 13:54:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+qo5ntVrsAUdxoFW46nFFT7VS/THwD9rNO3leC/egNs=; b=ly5H+MdluZ7P4cnvG+1pthcpg4/2Tjr19UgX7QCJSccAaGXeB/Kv4SDHUXc8rz3NlzHT6H5BNzZcRgUmUge/s5ZWZ+BU7mHf5TUz35Wt6sbW4h3rpSgrE4Ox9vUeBTn748t9gHPXfx9QiT0zaUYKzmPbEZruDZU7VpLFKsJHitlMUM5vkBUXf/Hl4MWeiUoS+rE1WpNbUp0K4Xk5VzTbwerLvgi0gq1SpZgbYie9SFqCTGlYWkZL8LIDkBGl1a6dOV0PKeG34ZI6AK4WNM07ieEkWBemkWMTz0yV/P3g8XZxErMQe0DI0VNS0xuxmqF6TODlAKyiSdHSC2HXs7XSnA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WB0wfvkpsAOfQXGjZw0YEtHqOvRjjzIpfXhq2t7RmL1e2BNfXvx0L/RZ5fOqt/NQBzYh6xL7kNKJFCE2C9LS1i69q9eiLwGC97SYMoE7gX7tJmfK1WiURhxE3caCYrjbnP/6RflqmM5B+tmqI7q2BAFg4J4KHAe2CENtGFeHcO1VqLCQOWTBY6pHdbOC5zx61WJkzy/uhV/pYfs0yyf/y0tGWRKscWrb0PRRVLigEyNbW1F6J3C8V0d4QlkF2tIt90Phuq2UmYJlBsuOZeHZ9xjjjGqFWusOlIfeZJe5J/zCZjSV8CSyROr4vCAZw3m8gJrGZVRPkRPvJKB4f0syyA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 11:54:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.07.2021 13:23, Andrew Cooper wrote:
> We shouldn't be using two struct iovec's to write half of 'rec' each, and
> there is no need to malloc() for two struct iovec's at all.
I was indeed wondering about all of these while also touching the
function. But I was guessing that there might be a deeper reason I
don't see.
> Simplify down to just two - one covering the whole of 'rec', and one covering
> the pfns array.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
