[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xen-foreign: Update the size for vcpu_guest_{core_regs, context}

  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 6 Jul 2021 16:07:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJIpvwo8QqpTK7WW+1RQbAa9950DtOgEGt9vLhVzg+M=; b=HGGeUzAZyunLBnQJIP4yHlhXsvvR/fo1LAXLmgeYCLFKIi9E9dKl3QH9UWyEKGZbWvdFejK76I2L032iBtExtl2A40+iJ3GNfyCLwnXpesbMcrQyzdfo6h4Vu+3dQNzHXE4KD+4g9DXklDFRC3LJOXnTEzT+yO++b2RU6f7wtgsRgU6QdXVDi6QplNRuty96E8EoCvYL63avUz4ObMoPVdQQMsVXF8ReFr4HHpS0lg6enrU/2WgOaJv7XqIPC44kGawUlXA7qYnS61cpAVzlQF1qT8J5MR4hQdKyvzXxBqiOCszpy1g1xo8N8Mv1MZZ7CsU900DzPSCrcGT/OVOk1Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VU3UntHuHZMcX4Szf1zdhcdAPS6dAv/XYfoJVWMLZ+YAstqDct8mNPVG9SryuQQCcuZU0msIJH1BRw82tKrsJAfVBQFehptquzU+Q55oE9OY0Fz6fw+nD/6EOmAWno82HyWxuYs+dyDxtSRp7O5OZwlPA88e1cczrBTgvrJelbzBzYQf6Mby/+Oi5gZNuyLEgR3Z0a4Z+E7chKhllxOhnATXe/RcaDNPk6RViHO/gLQD509dXB7aFYR9SHWf3U9B4nYr0N6E4lTghux51mrWpNd5cEuiCvIW73UUgWcjEO5buoxsRmmMyoWkTmMgk0bpr+I/Ec5S+SfCipJmKJLEPA==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, michal.orzel@xxxxxxx, olaf@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 06 Jul 2021 14:07:49 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06.07.2021 15:20, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> Commit 918b8842a852 ("arm64: Change type of hsr, cpsr, spsr_el1 to
> uint64_t") updated the size of the structure vcpu_guest_core_regs and
> indirectly vcpu_guest_context.
> On Arm, the two structures are only accessible to the tools and the
> hypervisor (and therefore stable). However, they are still checked

I suppose s/stable/not stable/ and ...

> by the scripts in tools/include/xen-foreign are not able to understand
> that.
> Ideally we should rework the scripts so we don't have to update
> the size for non-stable structure. But I don't have limited time

... s/don't/only/ ?

> to spend on the issue. So chose the simple solution and update
> the size accordingly.
> Note that we need to keep vcpu_guest_core_regs around because
> the structure is used by vcpu_guest_context and therefore the
> scripts expects the generated header to contain it.

If vcpu_guest_context is also tools-only, why does it need keeping
(for Arm)? IOW can't you drop vcpu_guest_core_regs from the scripts
altogether, and mark vcpu_guest_context with valid sizes for x86




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.