[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools: Fix CPSR/SPSR print size

  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 6 Jul 2021 15:23:08 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XdknrmO3W6/FX1t7jM2xHJ335gusEdFvtrfK6EXxgAE=; b=UPy6vGl1dKCTlgyVOcS98ocPaz8i974dJihYFKXVDnoIe/i/XGwgQpuamdWxLGi3esTKqJz5lgBLwnrJkxX1SPCLVph2u4OzZEAqgXPIye2xd0hCjGdv7tMsEybPcJAaAfmAwvGx67UpEBdOk/rFGLSPgTTIo+FyqrMPmTNwIUk3jnbTxArfa1Oq8WmXCEhzVIA+kqknXnAOvSVW4H4JBffebEBGf3b/DWoAPntcSZ1sO7nNyWclM2nWar2zJTeDTqkFwtdhG0ffHtYqtQbz7rjk+0Gk/FfsVrLvzT11N9+i6ZtGCdvHsLC9b6KuHBTnilaatR0YMqEO6bugCjcGeQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rqzhun0lfP0lpXtYFKuKrvt7J/WFg6CRGgWHg4msxaJsA3hCxtq61A/5nVZuJWtZMsrBBFsYgNNJ2vhMD0g+yyDWPZz2w/wHAk+c0H42/imxWO/j4AtZsML8GiuOG2NW/TuOGr6svfcVbRct0h0bzpdlTf5WqEG2yxxBXf4ddTigqF7PAaRhpTcMG4wUGqZJlo5O1ld85cWBPoJ5W875pOHQs10Mbds4DgPvZeylGaMEuQovsIAK6TRcyW6OX51eMtMIz6bI9OK2eaq3c20SUjE8EjMYICNMfyN0PD5SElMjoxU4xdf+EvyK0yrNvh+hLtpXu/mvtalDNBS2t+gBlQ==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "jgrall@xxxxxxxxxx" <jgrall@xxxxxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, "olaf@xxxxxxxxx" <olaf@xxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 15:23:37 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXcnkI0yrA0BW0E067MCMRzZDicKs2DqIAgAACDoA=
  • Thread-topic: [PATCH] tools: Fix CPSR/SPSR print size

Hi Julien,

> On 6 Jul 2021, at 16:15, Julien Grall <julien@xxxxxxx> wrote:
> Hi Bertrand,
> Thanks for the fix. I forgot to check the full tools build when sending the 
> first fix :(.
> On 06/07/2021 16:09, Bertrand Marquis wrote:
>> With the changes of register size introduced in
>> 918b8842a852e0e7446286f546724b1c63c56c66, CPSR and SPSR are now stored
>> as 64bit values.
>> Fix the print size to use 64bit type.
> Can you add a fixes tag? This makes easier to find bug fix in the tree.
> For this patch it would be:
> Fixes: 918b8842a852 ("arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t")

Sure. Patch incoming in the next minutes.

>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
> Just to confirm, with this patch and mine the tools build successfully on 
> 32-bit and 64-bit?

Yes I have a full build running with both patches added for arm32, arm64 and 


> Cheers,
> -- 
> Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.