[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing
- To: Robin Murphy <robin.murphy@xxxxxxx>
- From: Will Deacon <will@xxxxxxxxxx>
- Date: Tue, 6 Jul 2021 18:06:58 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, heikki.krogerus@xxxxxxxxxxxxxxx, thomas.hellstrom@xxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, joonas.lahtinen@xxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, chris@xxxxxxxxxxxxxxxxxx, grant.likely@xxxxxxx, paulus@xxxxxxxxx, Frank Rowand <frowand.list@xxxxxxxxx>, mingo@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Saravana Kannan <saravanak@xxxxxxxxxx>, mpe@xxxxxxxxxxxxxx, "Rafael J . Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>, bskeggs@xxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Thierry Reding <treding@xxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, matthew.auld@xxxxxxxxx, linux-devicetree <devicetree@xxxxxxxxxxxxxxx>, Jianxiong Gao <jxgao@xxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, maarten.lankhorst@xxxxxxxxxxxxxxx, airlied@xxxxxxxx, Dan Williams <dan.j.williams@xxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, jani.nikula@xxxxxxxxxxxxxxx, Nathan Chancellor <nathan@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, rodrigo.vivi@xxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Claire Chang <tientzu@xxxxxxxxxxxx>, boris.ostrovsky@xxxxxxxxxx, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, jgross@xxxxxxxx, Nicolas Boichat <drinkcat@xxxxxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>, Qian Cai <quic_qiancai@xxxxxxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, "list@xxxxxxx:IOMMU DRIVERS" <iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Jim Quinlan <james.quinlan@xxxxxxxxxxxx>, xypron.glpk@xxxxxx, Tom Lendacky <thomas.lendacky@xxxxxxx>, bauerman@xxxxxxxxxxxxx
- Delivery-date: Tue, 06 Jul 2021 17:07:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 06, 2021 at 04:39:11PM +0100, Robin Murphy wrote:
> On 2021-07-06 15:05, Christoph Hellwig wrote:
> > On Tue, Jul 06, 2021 at 03:01:04PM +0100, Robin Murphy wrote:
> > > FWIW I was pondering the question of whether to do something along those
> > > lines or just scrap the default assignment entirely, so since I hadn't got
> > > round to saying that I've gone ahead and hacked up the alternative
> > > (similarly untested) for comparison :)
> > >
> > > TBH I'm still not sure which one I prefer...
> >
> > Claire did implement something like your suggestion originally, but
> > I don't really like it as it doesn't scale for adding multiple global
> > pools, e.g. for the 64-bit addressable one for the various encrypted
> > secure guest schemes.
>
> Ah yes, that had slipped my mind, and it's a fair point indeed. Since we're
> not concerned with a minimal fix for backports anyway I'm more than happy to
> focus on Will's approach. Another thing is that that looks to take us a
> quiet step closer to the possibility of dynamically resizing a SWIOTLB pool,
> which is something that some of the hypervisor protection schemes looking to
> build on top of this series may want to explore at some point.
Ok, I'll split that nasty diff I posted up into a reviewable series and we
can take it from there.
Will
|