[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm: Fix arch_initialise_vcpu to be unsupported


  • To: Michal Orzel <Michal.Orzel@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 6 Jul 2021 17:09:38 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjJUiH96IYTbPVoFZr5RR6KjTNi7tXBgKw0jMmmQMcI=; b=A68eXCoDxiXLbj4Xw8m/XU9F/9JX5xs/IrUKdkdUYqFB+Y5KpO3OujoATqyAw4RbpPfjbnLVXzHBiNUIW8Xk8fIOZMiXbFqZV8IDGSYQI93RaFEdZTqNerbtxmrRmevjcb5nOO3fsx73c3OfYmCexqVa13jTk31vjSNmH/3hy9p9rvu0479HtxXXH8tXf09RulOwqgTbVa9LMf+UMFV8/d+6BLMgD1aWQUjEB6TNc6yyS4ajb4bkXHJMFGdVp3tOjCHVZFZbh46ENHdMG9Z/Pj+6VtdQdsGScBY0PHPPELJjQtIx0bS+iA47UmWIUBCyNio+3vYFwRr4uQeAydrfsw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOsWvAwxUEzcKPiRFQojQw0IaZIByyW7SkreKR5DtfSwgXhx821ACPT0atkqB2QOJzIbrhMbmVW6oNY1RS5ovgVrB5lGigv2L1EC9N6WES5f8zfL6Wvxmi1veFCzyUX2EUU76f3XYMsW2lbaebowmQKm8pqedDqj14uw3DkkSaJ0XkxwljSWsDGCtSN304BuNLcgcLqCa4JFCWTUsOk8iryMZqXt01YNkNMYtXXnknG0HIbhI1EtxEHGsPJY2M+9744wbD3I+u25iYjeZGNLmdntqx8wW39LV9tGxLyoJVgNCRQtazwJYpEapQnkoUTqfmPCYDAciSlQ/egelfweDw==
  • Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 17:09:51 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXclHJWHwKNGJKDUOBs2jUzEf/E6s2LsEA
  • Thread-topic: [PATCH] arm: Fix arch_initialise_vcpu to be unsupported

Hi Michal,

> On 6 Jul 2021, at 11:28, Michal Orzel <Michal.Orzel@xxxxxxx> wrote:
> 
> Function arch_initialise_vcpu is not reachable as the
> VCPUOP_initialise is an unsupported operation on arm.
> Modify the function by adding ASSERT_UNREACHABLE() and
> returning -EOPNOTSUPP.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Cheers
Bertrand

> ---
> xen/arch/arm/domain.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index c021a03c61..a2aa8b77ad 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -923,7 +923,8 @@ int arch_set_info_guest(
> 
> int arch_initialise_vcpu(struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg)
> {
> -    return default_initialise_vcpu(v, arg);
> +    ASSERT_UNREACHABLE();
> +    return -EOPNOTSUPP;
> }
> 
> int arch_vcpu_reset(struct vcpu *v)
> -- 
> 2.29.0
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.