[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] tools/go: honor append build flags


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Wed, 7 Jul 2021 09:15:31 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cs8ymGBrF7j+G3jCG9nSDz3vu1J1AeR1C6gb1yeBOWs=; b=hS0Zfklq47yNX4uWsgsDUAhUXdYZXk/n2/kO1fiHTh5jXOvfyqNGS/OiAjWFWdNP3lkTYWWUL/G1TlPmG5CHpVbkoW1gUN4yQISkpKKhmFJPwl9zsURfd2Aha+0MAObXkhuWw1Wux20LO2wjrZ31zW4StnUXASNJKL7XTziRWvVR/CKAm7RK7+ERj2OjzTMDrEyxLy9FZkSPzOnmkZ4QzpHp7NkaApLGudj6Zq9x0dc1ff7cUVOjwF5ifo5FmClfSlSnOWf2k6HYCyindihbJR/mEWxc39lN+Q1jmpp8H5O1s3SI3Svl2fFd0anubPqQZRnnhJS37Pd4qPm0jckBBQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=brFRIP6Mshp81an9xbdl90u/u5gWDJLvQUFJ88F0UNZMvGtXqsKOsdtBZcmJeBIkLbzYWDNcpyA9mxt95oIyGIGnoypkCgEpOoybkDpk+jb6wgSYXSbR5T7ElDVueNJn3Tlq170NTY9Vh1wjNm6pxhAAmKcZoo1qNYGFvmJ5QmKd6Gp2rIY9THhnoNWwDmFmsEEutBJlVPlyaLEPxoyx9IPkQqXliCrhr8Xwlsg0WDdVEdTXDd3R5M9VWex5ao4DdrgcwLvkq6byghBY5/hcJvzUUW704ir8+HXW7QWl6S07GnZyaCxkFd/IjuCB59+gx+qGOjRBqHi7J7yxdyH3uw==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ting-Wei Lan <lantw44@xxxxxxxxx>
  • Delivery-date: Wed, 07 Jul 2021 07:15:57 +0000
  • Ironport-hdrordr: A9a23:3rPjPqN+3FA2T8BcTvajsMiBIKoaSvp037BN7SxMoH1uHfBw8v rEoB1173HJYVoqOU3I++rwXZVoMEm9yXcd2+B4V9qftW/dyQiVxa5ZnO3fKlbbaknDH4BmpM VdWpk7JNrsDUVryebWiTPIa+rIGeP3iZxBD43lvhBQcT0=
  • Ironport-sdr: cvPudFtrfMEzYPEQToFdFSIQVoZMB0n4yyvarWtLGSmnL/N2c367yhiMJIfGHeAJYa36GXClYG CT7SfgbvFloKFXWsbKjK08T46fIsrGwJWQ1GyybKeP40ssRTS9/2iNgp3eiYte7zYoaUfI85ds /WkT6ikjKraHluUuwRmilZavIe1nZmypyZK4dDoQXI2UPzfWGtHWy/pEz87hgDvJSDylGcdk9d KF603FhY/arr4tsJTTUHbyjWpdu4WpJ2mk0dAlfeFvF9Kvda2t3U+Z9Q0ytr/SEokrZlb5uPnj gIA=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Make the go build use APPEND_{C/LD}FLAGS when necessary, just like
other parts of the build.

Reported-by: Ting-Wei Lan <lantw44@xxxxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
Note sure if it's the best way to add the appended flags, I'm not
familiar with the go build system. In any case this fixes the build
when required libraries (ie: yajl) are not part of the system search
path and instead passed in APPEND_{C/LD}FLAGS.
---
 tools/golang/xenlight/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
index e394ef9b2b..64671f246c 100644
--- a/tools/golang/xenlight/Makefile
+++ b/tools/golang/xenlight/Makefile
@@ -27,7 +27,7 @@ GOXL_GEN_FILES = types.gen.go helpers.gen.go
 # so that it can find the actual library.
 .PHONY: build
 build: xenlight.go $(GOXL_GEN_FILES)
-       CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog)" 
CGO_LDFLAGS="$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -L$(XEN_libxenlight) 
-L$(XEN_libxentoollog)" $(GO) build -x
+       CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) 
$(APPEND_CFLAGS)" CGO_LDFLAGS="$(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) 
-L$(XEN_libxenlight) -L$(XEN_libxentoollog) $(APPEND_LDFLAGS)" $(GO) build -x
 
 .PHONY: install
 install: build
-- 
2.31.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.