[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission


  • To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Wed, 7 Jul 2021 08:48:40 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dxyu8WD+lPu/fW4qAOY7KHzCx9GOPJkrLIVAG5vdQZw=; b=XVTwoywrR1Bo5/AJcYtESu5pgqWTUBHYjZ+MeJXbyGI6PrvXm9qwB8Pd7hGluN6tqJO+RQKLu8LHNNwkyTj4vFJlNaqXyp/xwzGui1NMJuJ2YSGbcWoCV+rXyouxnvv/oJa3Ru5xPb+GiRATZk6oUKYUKyhqP5mjyZClB7d2c1yQ+7LQAEDNvhHiCCTj/MJJrdF4UwojGs1GvBKv14naeFk0PmQ5ckmzRlRCpI3k8rjtYMtNJflX/WYjYuzER+n7MprYrPXQG8WiLPazTkRkjwtVEfDXCSp4K/3HuaR793w8rszehxS8VCOlh2i4VFxKL0s9korAeqjpnnjbm4qVJQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RjqNt6g0W8oKSRDJptCdcFua7FS7zGT8xm5V/X6h8TX8pzwDtZl+jYPZghTXc43K2Mv/cho7tXVWrYV/cvGEetfWIh3uiKmiDRmbk95Do4P5K/xLy3xKaNcESQBgJ/Ndbc/OjWsqsrLBaeKIQk/4u6e2Ej6qKww3Fv1tX96q6Zs02BbsgOBYxmN8NqqQgIGdwp/DhXOH67DvBZEEFqmAdmqkd9fq8tvNAEVazH2PiImekf1YASNTWyL7cGqYnLP3BzxzwloOKqH1prG76lraw4+rZPURjglDcB1Yp2TFJkhJXfA7y854C4QiGUiZcfwfgPvps6jPj2Z1/Z07UjhmoA==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, "dave@xxxxxxxxxx" <dave@xxxxxxxxxx>
  • Delivery-date: Wed, 07 Jul 2021 08:49:01 +0000
  • Ironport-hdrordr: A9a23:crRD3qHKcFSXJ3VdpLqFY5HXdLJyesId70hD6qkvc3Nom52j+/ xGws536fatskdtZJkh8erwXZVoMkmsiaKdgLNhcotKOTOJhILGFvAa0WKP+UyCJ8S6zJ8m6U 4CSdkxNDSTNykDsS+S2mDReLxAoOVvsprY/ts2p00dFT2CAJsQizuRfzzrdHGeMzM2YqbReq DshPZvln6FQzA6f867Dn4KU6zovNvQjq/rZhYAGloO9BSOpSnA0s+6LzGomjMlFx9fy7Yr9m bI1ybj4L+4jv29whjAk0fO8pVtnsf7wNcrPr3NtiFVEESutu+bXvUlZ1SwhkFwnAhp0idsrD D4mWZjAy200QKWQoj6m2q15+Cq6kdQ15ar8y7nvZKkm72jeNtyMbswuatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAhqqIlyUBS4NL7okYvGbf2UoUh5rD3PXklZ6soDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blnwR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjibGgP1Jt3ck4ljqSHlIndyNvaCqDg/aFC7q gpCmkoxlLaU3iefPGz4A==
  • Ironport-sdr: tEB3pzazbTMA9XG0yKEZjoTQp1ptDgoTYBJoZFhdYDfJOFwgTQCUCQnSEIkqUV7D2z7qO7v14r jGSP+djY4FNoh7VkfMHMzmVjliRFrbHFDzoeONkCK6JqZZ5EGUh9NYh1f0syc+2giS8X10jVoC fDLVTmZq5awroTiihdPj4JVUQrjRANGyk+tUNuoqe7IH7kAHgwH3C8gIOTgabmPNUq8yl2oKQr VRx3MO+4r0lJtM9WMGCYUIy3Tmsg/PRDYxp8nFjVjRKIaU4uO5gACxmyscyqwPTNkHDnIw+Twf +TQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXcsvXTynNtpWrykaXALTlaqCPOqs3NCuA
  • Thread-topic: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission



On 7 Jul 2021, at 02:02, Igor Druzhinin <igor.druzhinin@xxxxxxxxxx> wrote:

Current unit8_t for pirq argument in this interface is too restrictive
causing failures on modern hardware with lots of GSIs. That extends down to
XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up
as well. Internal Xen structures appear to be fine. Existing users of
the interface in tree (libxl, ocaml and python bindings) are already using
int for pirq representation that should be wide enough.

Domctl interface version is needed to be bumped with this change but that
was already done by 918b8842a8 ("arm64: Change type of hsr, cpsr, spsr_el1
to uint64_t") in this release cycle.

Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>
---
tools/include/xenctrl.h             | 2 +-
tools/libs/ctrl/xc_domain.c         | 2 +-
tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +-
xen/include/public/domctl.h         | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.