[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] IOMMU: correct parsing of "quarantine=scratch-page"


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 7 Jul 2021 15:21:51 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fncpQ+McTCrlAfJoD70a97RLi0M1zPqC/GNQoM1kqag=; b=GrB2pUfZdnXi05f8vSmSaaV3MNfbpNYWwpPN2RUsw4zFkoXfDq/zosXWn5CqqiKqB8yyd5zw0iPgSj0sCn1mUFN9lVzeBmd/d+/hIm1S/OP/mTU3onbpiH9J2Ek0huCJ1cnZ6tA87OyEchAmLV8DrH4sEZOoqVzTDegg3nvDCkZOYStcK6kSZDJUwXMNNUoDf2zYdVUNHxy2eE8A8LwDf63dpDKcDwg1e32/K9jt4pqcgfgMkwYPSuZxX9J9SSk3WcTP9WDZnPxWZ+zk3a3rZZbmWW8NGitPKYzMjAUkBLLmln6CBbbBlp5g/TGZpM2N5QLl5TqtOqJne3cFRaWxog==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0N86sDZCIe98xMT1VbEClNpaGvTgaj7ZCZBOc0TAMZhX41GzpWkCLb0IPD4X1+GMbIrCx76keLDtw+bfY2OyE5et1XfLY5PFVUvnw1pAh5XC9rd9lH6hy1ibRzjsJgeZFbsylsP0NHqjpLo1orhJw/T2EAFavOyMDy2p7hlNKrjlZv2MwxDBpGNzbAm4LlbBLvdIZqbLTVV6WofQSp67KGT7IwGqUsDu2YvAM8LvkYE2279yF4C7h7Vq9SQE1HPvUMkRnaywPDyPijdi+uZuhEHu3jMeelBoNNNKoQ9iX+wL3kgY5GXCQSVkCkSvBsDC4MeyViHbumY1QPGdfFPGw==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Wed, 07 Jul 2021 13:21:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

During the multiple renames of the sub-option I apparently forgot to
update the left side of the &&, and this pretty consistently.

Fixes: 980d6acf1517 ("IOMMU: make DMA containment of quarantined devices 
optional")

Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -82,7 +82,7 @@ static int __init parse_iommu_param(cons
 #ifdef CONFIG_HAS_PCI
         else if ( (val = parse_boolean("quarantine", s, ss)) >= 0 )
             iommu_quarantine = val;
-        else if ( ss == s + 15 && !strncmp(s, "quarantine=scratch-page", 23) )
+        else if ( ss == s + 23 && !strncmp(s, "quarantine=scratch-page", 23) )
             iommu_quarantine = IOMMU_quarantine_scratch_page;
 #endif
 #ifdef CONFIG_X86




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.